linux-kernel - Re: [PATCH v2 03/28] mm/cma: introduce cma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z63FN1+f+Ca2owdm@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
Date: Thu, 13 Feb 2025 11:11:03 +0100
From: Alexander Gordeev <agordeev@...ux.ibm.com>
To: Frank van der Linden <fvdl@...gle.com>
Cc: akpm@...ux-foundation.org, muchun.song@...ux.dev, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, yuzhao@...gle.com,
        usamaarif642@...il.com, joao.m.martins@...cle.com,
        roman.gushchin@...ux.dev, Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>, linux-s390@...r.kernel.org
Subject: Re: [PATCH v2 03/28] mm/cma: introduce cma_intersects function

On Wed, Jan 29, 2025 at 10:41:32PM +0000, Frank van der Linden wrote:
> Now that CMA areas can have multiple physical ranges,
> code can't assume a CMA struct represents a base_pfn
> plus a size, as returned from cma_get_base.
> 
> Most cases are ok though, since they all explicitly
> refer to CMA areas that were created using existing
> interfaces (cma_declare_contiguous_nid or
> cma_init_reserved_mem), which guarantees they have just
> one physical range.
> 
> An exception is the s390 code, which walks all CMA
> ranges to see if they intersect with a range of memory
> that is about to be hotremoved. So, in the future,
> it might run in to multi-range areas. To keep this check
> working, define a cma_intersects function. This just checks
> if a physaddr range intersects any of the ranges.
> Use it in the s390 check.
> 
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: Alexander Gordeev <agordeev@...ux.ibm.com>
> Cc: linux-s390@...r.kernel.org
> Signed-off-by: Frank van der Linden <fvdl@...gle.com>
> ---
>  arch/s390/mm/init.c | 13 +++++--------
>  include/linux/cma.h |  1 +
>  mm/cma.c            | 21 +++++++++++++++++++++
>  3 files changed, 27 insertions(+), 8 deletions(-)

Acked-by: Alexander Gordeev <agordeev@...ux.ibm.com>