linux-kernel - Re: [PATCH RESEND 0/5] LED1202 / leds-st1202 fixes and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250213104119.GD2756671@google.com>
Date: Thu, 13 Feb 2025 10:41:19 +0000
From: Lee Jones <lee@...nel.org>
To: Manuel Fombuena <fombuena@...look.com>
Cc: pavel@....cz, corbet@....net, linux-leds@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 0/5] LED1202 / leds-st1202 fixes and improvements

On Sat, 01 Feb 2025, Manuel Fombuena wrote:

> Collection of patches for the recently added leds-st1202 driver. It is the
> same patchset sent on 2025-01-17. The cover letter wasn't properly threaded
> with the patches that time, so apologies for that.
> 
> Obvious from the individual descriptions, but as a summary:
> 
> - 0001: fix a NULL pointer access error that occurs when LEDs are
> registered but the LED driver is not fully initialized
> - 0002: initialize the LED driver before any DT LED initialization is done
> - 0003: some spacing and typo edits
> - 0004: include the appropriate select in Kconfig to make sure the
> required Pattern trigger driver is available.
> - 0005: remove .rst extension on Documentation/leds/index.rst

Stripping the separators from patch file names and pasting them
culminates in a terrible summary.  In no way does this cover-letter
describe what you're trying to achieve, why you're trying to achieve it
and the consequences for not applying the set.  Nor does it communicate
any merge intentions (which is required due to the assumptions made, as
described in our previous conversation).

-- 
Lee Jones [李琼斯]