linux-kernel - Re: [PATCH v2 1/2] blk-wbt: Fix some comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76cd73b1-52f5-1f19-ae37-c856a765ebc4@huaweicloud.com>
Date: Thu, 13 Feb 2025 19:04:40 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: Tang Yizhou <yizhou.tang@...pee.com>, yukuai1@...weicloud.com,
 axboe@...nel.dk
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH v2 1/2] blk-wbt: Fix some comments

Hi,

在 2025/02/13 18:06, Tang Yizhou 写道:
> From: Tang Yizhou <yizhou.tang@...pee.com>
> 
> wbt_wait() no longer uses a spinlock as a parameter. Update the function
> comments accordingly.
> 
> RWB_UNKNOWN_BUMP is used when we gradually adjust scale_steps toward the
> center state, which is a value of 0.
> 
> Signed-off-by: Tang Yizhou <yizhou.tang@...pee.com>
> ---
>   block/blk-wbt.c | 11 ++++-------
>   1 file changed, 4 insertions(+), 7 deletions(-)
> 

LGTM
Reviewed-by: Yu Kuai <yukuai3@...wei.com>

> diff --git a/block/blk-wbt.c b/block/blk-wbt.c
> index 6dfc659d22e2..8b73c0c11aec 100644
> --- a/block/blk-wbt.c
> +++ b/block/blk-wbt.c
> @@ -136,8 +136,9 @@ enum {
>   	RWB_MIN_WRITE_SAMPLES	= 3,
>   
>   	/*
> -	 * If we have this number of consecutive windows with not enough
> -	 * information to scale up or down, scale up.
> +	 * If we have this number of consecutive windows without enough
> +	 * information to scale up or down, slowly return to center state
> +	 * (step == 0).
>   	 */
>   	RWB_UNKNOWN_BUMP	= 5,
>   };
> @@ -638,11 +639,7 @@ static void wbt_cleanup(struct rq_qos *rqos, struct bio *bio)
>   	__wbt_done(rqos, flags);
>   }
>   
> -/*
> - * May sleep, if we have exceeded the writeback limits. Caller can pass
> - * in an irq held spinlock, if it holds one when calling this function.
> - * If we do sleep, we'll release and re-grab it.
> - */
> +/* May sleep, if we have exceeded the writeback limits. */
>   static void wbt_wait(struct rq_qos *rqos, struct bio *bio)
>   {
>   	struct rq_wb *rwb = RQWB(rqos);
>