linux-kernel - Re: [PATCH 2/4] mm: Make DEBUG_WX depdendent on GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0141324f-19e9-4e40-9500-df3bc140f2d0@arm.com>
Date: Thu, 13 Feb 2025 11:23:07 +0000
From: Steven Price <steven.price@....com>
To: Anshuman Khandual <anshuman.khandual@....com>, linux-mm@...ck.org
Cc: christophe.leroy@...roup.eu, Andrew Morton <akpm@...ux-foundation.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] mm: Make DEBUG_WX depdendent on GENERIC_PTDUMP

On 13/02/2025 04:09, Anshuman Khandual wrote:
> DEBUG_WX selects PTDUMP_CORE without even ensuring that the given platform
> implements GENERIC_PTDUMP. This problem has been latent until now, as all
> the platforms subscribing ARCH_HAS_DEBUG_WX also subscribe GENERIC_PTDUMP.
> 
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: linux-mm@...ck.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@....com>

Reviewed-by: Steven Price <steven.price@....com>

> ---
>  mm/Kconfig.debug | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug
> index 41a58536531d..a51a1149909a 100644
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug
> @@ -186,6 +186,7 @@ config ARCH_HAS_DEBUG_WX
>  config DEBUG_WX
>  	bool "Warn on W+X mappings at boot"
>  	depends on ARCH_HAS_DEBUG_WX
> +	depends on GENERIC_PTDUMP
>  	depends on MMU
>  	select PTDUMP_CORE
>  	help