| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202502131939.DdTP5mv1-lkp@intel.com>
Date: Thu, 13 Feb 2025 19:39:08 +0800
From: kernel test robot <lkp@...el.com>
To: Philipp Stanner <phasta@...nel.org>,
Andrew Lunn <andrew+netdev@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Serge Semin <fancer.lancer@...il.com>,
Huacai Chen <chenhuacai@...nel.org>,
Yinggang Gu <guyinggang@...ngson.cn>,
Yanteng Si <si.yanteng@...ux.dev>,
Philipp Stanner <pstanner@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] stmmac: Replace deprecated PCI functions
Hi Philipp,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.14-rc2 next-20250213]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Philipp-Stanner/stmmac-Replace-deprecated-PCI-functions/20250212-230254
base: linus/master
patch link: https://lore.kernel.org/r/20250212145831.101719-2-phasta%40kernel.org
patch subject: [PATCH] stmmac: Replace deprecated PCI functions
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20250213/202502131939.DdTP5mv1-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250213/202502131939.DdTP5mv1-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502131939.DdTP5mv1-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c: In function 'loongson_dwmac_probe':
>> drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c:527:18: warning: unused variable 'i' [-Wunused-variable]
527 | int ret, i;
| ^
drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c: In function 'loongson_dwmac_remove':
drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c:604:13: warning: unused variable 'i' [-Wunused-variable]
604 | int i;
| ^
vim +/i +527 drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
126f4f96c41d2e Yanteng Si 2024-08-07 520
30bba69d7db40e Qing Zhang 2021-06-18 521 static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id *id)
30bba69d7db40e Qing Zhang 2021-06-18 522 {
30bba69d7db40e Qing Zhang 2021-06-18 523 struct plat_stmmacenet_data *plat;
0ec04d32b5e7f0 Yanteng Si 2024-08-07 524 struct stmmac_pci_info *info;
bd83fd598ba34f Philipp Stanner 2025-02-12 525 struct stmmac_resources res = {};
803fc61df261de Yanteng Si 2024-08-07 526 struct loongson_data *ld;
126f4f96c41d2e Yanteng Si 2024-08-07 @527 int ret, i;
30bba69d7db40e Qing Zhang 2021-06-18 528
30bba69d7db40e Qing Zhang 2021-06-18 529 plat = devm_kzalloc(&pdev->dev, sizeof(*plat), GFP_KERNEL);
30bba69d7db40e Qing Zhang 2021-06-18 530 if (!plat)
30bba69d7db40e Qing Zhang 2021-06-18 531 return -ENOMEM;
30bba69d7db40e Qing Zhang 2021-06-18 532
30bba69d7db40e Qing Zhang 2021-06-18 533 plat->mdio_bus_data = devm_kzalloc(&pdev->dev,
30bba69d7db40e Qing Zhang 2021-06-18 534 sizeof(*plat->mdio_bus_data),
30bba69d7db40e Qing Zhang 2021-06-18 535 GFP_KERNEL);
e87d3a1370ce9f Yanteng Si 2023-12-11 536 if (!plat->mdio_bus_data)
e87d3a1370ce9f Yanteng Si 2023-12-11 537 return -ENOMEM;
e87d3a1370ce9f Yanteng Si 2023-12-11 538
30bba69d7db40e Qing Zhang 2021-06-18 539 plat->dma_cfg = devm_kzalloc(&pdev->dev, sizeof(*plat->dma_cfg), GFP_KERNEL);
126f4f96c41d2e Yanteng Si 2024-08-07 540 if (!plat->dma_cfg)
126f4f96c41d2e Yanteng Si 2024-08-07 541 return -ENOMEM;
30bba69d7db40e Qing Zhang 2021-06-18 542
803fc61df261de Yanteng Si 2024-08-07 543 ld = devm_kzalloc(&pdev->dev, sizeof(*ld), GFP_KERNEL);
803fc61df261de Yanteng Si 2024-08-07 544 if (!ld)
803fc61df261de Yanteng Si 2024-08-07 545 return -ENOMEM;
803fc61df261de Yanteng Si 2024-08-07 546
30bba69d7db40e Qing Zhang 2021-06-18 547 /* Enable pci device */
30bba69d7db40e Qing Zhang 2021-06-18 548 ret = pci_enable_device(pdev);
30bba69d7db40e Qing Zhang 2021-06-18 549 if (ret) {
30bba69d7db40e Qing Zhang 2021-06-18 550 dev_err(&pdev->dev, "%s: ERROR: failed to enable device\n", __func__);
126f4f96c41d2e Yanteng Si 2024-08-07 551 return ret;
30bba69d7db40e Qing Zhang 2021-06-18 552 }
30bba69d7db40e Qing Zhang 2021-06-18 553
126f4f96c41d2e Yanteng Si 2024-08-07 554 pci_set_master(pdev);
126f4f96c41d2e Yanteng Si 2024-08-07 555
30bba69d7db40e Qing Zhang 2021-06-18 556 /* Get the base address of device */
bd83fd598ba34f Philipp Stanner 2025-02-12 557 res.addr = pcim_iomap_region(pdev, 0, DRIVER_NAME);
bd83fd598ba34f Philipp Stanner 2025-02-12 558 ret = PTR_ERR_OR_ZERO(res.addr);
30bba69d7db40e Qing Zhang 2021-06-18 559 if (ret)
fe5b3ce8b4377e Yang Yingliang 2022-11-08 560 goto err_disable_device;
30bba69d7db40e Qing Zhang 2021-06-18 561
803fc61df261de Yanteng Si 2024-08-07 562 plat->bsp_priv = ld;
803fc61df261de Yanteng Si 2024-08-07 563 plat->setup = loongson_dwmac_setup;
56dbe2c290bc58 Yanteng Si 2024-08-07 564 ld->dev = &pdev->dev;
803fc61df261de Yanteng Si 2024-08-07 565 ld->loongson_id = readl(res.addr + GMAC_VERSION) & 0xff;
803fc61df261de Yanteng Si 2024-08-07 566
0ec04d32b5e7f0 Yanteng Si 2024-08-07 567 info = (struct stmmac_pci_info *)id->driver_data;
126f4f96c41d2e Yanteng Si 2024-08-07 568 ret = info->setup(pdev, plat);
0ec04d32b5e7f0 Yanteng Si 2024-08-07 569 if (ret)
0ec04d32b5e7f0 Yanteng Si 2024-08-07 570 goto err_disable_device;
0ec04d32b5e7f0 Yanteng Si 2024-08-07 571
126f4f96c41d2e Yanteng Si 2024-08-07 572 if (dev_of_node(&pdev->dev))
126f4f96c41d2e Yanteng Si 2024-08-07 573 ret = loongson_dwmac_dt_config(pdev, plat, &res);
126f4f96c41d2e Yanteng Si 2024-08-07 574 else
126f4f96c41d2e Yanteng Si 2024-08-07 575 ret = loongson_dwmac_acpi_config(pdev, plat, &res);
126f4f96c41d2e Yanteng Si 2024-08-07 576 if (ret)
0c979e6b55f99f Yanteng Si 2024-08-07 577 goto err_disable_device;
30bba69d7db40e Qing Zhang 2021-06-18 578
803fc61df261de Yanteng Si 2024-08-07 579 /* Use the common MAC IRQ if per-channel MSIs allocation failed */
803fc61df261de Yanteng Si 2024-08-07 580 if (ld->loongson_id == DWMAC_CORE_LS_MULTICHAN)
803fc61df261de Yanteng Si 2024-08-07 581 loongson_dwmac_msi_config(pdev, plat, &res);
803fc61df261de Yanteng Si 2024-08-07 582
f2d45fdf9a0ed2 Yang Yingliang 2022-11-08 583 ret = stmmac_dvr_probe(&pdev->dev, plat, &res);
f2d45fdf9a0ed2 Yang Yingliang 2022-11-08 584 if (ret)
126f4f96c41d2e Yanteng Si 2024-08-07 585 goto err_plat_clear;
f2d45fdf9a0ed2 Yang Yingliang 2022-11-08 586
126f4f96c41d2e Yanteng Si 2024-08-07 587 return 0;
f2d45fdf9a0ed2 Yang Yingliang 2022-11-08 588
126f4f96c41d2e Yanteng Si 2024-08-07 589 err_plat_clear:
126f4f96c41d2e Yanteng Si 2024-08-07 590 if (dev_of_node(&pdev->dev))
126f4f96c41d2e Yanteng Si 2024-08-07 591 loongson_dwmac_dt_clear(pdev, plat);
803fc61df261de Yanteng Si 2024-08-07 592 if (ld->loongson_id == DWMAC_CORE_LS_MULTICHAN)
803fc61df261de Yanteng Si 2024-08-07 593 loongson_dwmac_msi_clear(pdev);
fe5b3ce8b4377e Yang Yingliang 2022-11-08 594 err_disable_device:
fe5b3ce8b4377e Yang Yingliang 2022-11-08 595 pci_disable_device(pdev);
f2d45fdf9a0ed2 Yang Yingliang 2022-11-08 596 return ret;
30bba69d7db40e Qing Zhang 2021-06-18 597 }
30bba69d7db40e Qing Zhang 2021-06-18 598
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists