linux-kernel - Re: [PATCH] tls: Check return value of get_cipher_desc in fill_sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250212174410.42d9ceac@kernel.org>
Date: Wed, 12 Feb 2025 17:44:10 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: borisp@...dia.com, john.fastabend@...il.com, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, pabeni@...hat.com, edumazet@...gle.com,
 horms@...nel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH] tls: Check return value of get_cipher_desc in
 fill_sg_out

On Wed, 12 Feb 2025 10:53:50 +0800 Wentao Liang wrote:
> The function get_cipher_desc() may return NULL if the cipher type is
> invalid or unsupported. In fill_sg_out(), the return value is used
> without any checks, which could lead to a NULL pointer dereference.
> 
> This patch adds a DEBUG_NET_WARN_ON_ONCE check to ensure that
> cipher_desc is valid and offloadable before proceeding. This prevents
> potential crashes and provides a clear warning in debug builds.

Does not make any sense, the state is validated during configuration.
-- 
pw-bot: reject
pv-bot: llm