linux-kernel - Re: [PATCH v3] RDMA/irdma: switch to using the crc32c library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173945056532.293287.14692956092199432239.b4-ty@kernel.org>
Date: Thu, 13 Feb 2025 07:42:45 -0500
From: Leon Romanovsky <leon@...nel.org>
To: Mustafa Ismail <mustafa.ismail@...el.com>, 
 Tatyana Nikolova <tatyana.e.nikolova@...el.com>, 
 Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org, 
 Eric Biggers <ebiggers@...nel.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] RDMA/irdma: switch to using the crc32c library


On Thu, 06 Feb 2025 20:08:16 -0800, Eric Biggers wrote:
> Now that the crc32c() library function directly takes advantage of
> architecture-specific optimizations, it is unnecessary to go through the
> crypto API.  Just use crc32c().  This is much simpler, and it improves
> performance due to eliminating the crypto API overhead.
> 
> Note that for crc32c the equivalent of crypto_shash_digest() is
> cpu_to_le32(~crc32c(~0, ...)), considering that crypto_shash_digest()
> had before and inversions as well as a cpu_to_le32() built-in.  This
> means that this driver is using u32 for fixed-endian types; this patch
> does not try to fix that but rather just keep the exact same behavior.
> 
> [...]

Applied, thanks!

[1/1] RDMA/irdma: switch to using the crc32c library
      https://git.kernel.org/rdma/rdma/c/7fed5876df3d02

Best regards,
-- 
Leon Romanovsky <leon@...nel.org>