linux-kernel - Re: [PATCH] ASoC: Intel: avs: Use str_on_off() in avs_dsp_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c59618b-a9a6-4a0f-8200-2b7152dfe40c@intel.com>
Date: Thu, 13 Feb 2025 14:38:59 +0100
From: Cezary Rojewski <cezary.rojewski@...el.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
CC: <linux-sound@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Liam
 Girdwood" <liam.r.girdwood@...ux.intel.com>, Peter Ujfalusi
	<peter.ujfalusi@...ux.intel.com>, Bard Liao
	<yung-chuan.liao@...ux.intel.com>, Ranjani Sridharan
	<ranjani.sridharan@...ux.intel.com>, Kai Vehmanen
	<kai.vehmanen@...ux.intel.com>, Pierre-Louis Bossart
	<pierre-louis.bossart@...ux.dev>, Mark Brown <broonie@...nel.org>, "Jaroslav
 Kysela" <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH] ASoC: Intel: avs: Use str_on_off() in
 avs_dsp_core_power()

On 2025-02-12 10:12 AM, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_on_off() helper function.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>   sound/soc/intel/avs/dsp.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/avs/dsp.c b/sound/soc/intel/avs/dsp.c
> index 7b47e52c2b39..b9de691e9b9b 100644
> --- a/sound/soc/intel/avs/dsp.c
> +++ b/sound/soc/intel/avs/dsp.c
> @@ -6,6 +6,7 @@
>   //          Amadeusz Slawinski <amadeuszx.slawinski@...ux.intel.com>
>   //
>   
> +#include <linux/string_choices.h>
>   #include <sound/hdaudio_ext.h>
>   #include "avs.h"
>   #include "registers.h"
> @@ -39,7 +40,7 @@ int avs_dsp_core_power(struct avs_dev *adev, u32 core_mask, bool power)
>   				       AVS_ADSPCS_TIMEOUT_US);
>   	if (ret)
>   		dev_err(adev->dev, "core_mask %d power %s failed: %d\n",
> -			core_mask, power ? "on" : "off", ret);
> +			core_mask, str_on_off(power), ret);
>   
>   	return ret;
>   }

LGTM

Reviewed-by: Cezary Rojewski <cezary.rojewski@...el.com>