linux-kernel - Re: [PATCH v2 05/15] drm/vkms: Extract vkms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z636vaJLmJ9RGI6L@louis-chauvet-laptop>
Date: Thu, 13 Feb 2025 14:59:25 +0100
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: José Expósito <jose.exposito89@...il.com>
Cc: hamohammed.sa@...il.com, simona@...ll.ch, melissa.srw@...il.com,
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
	tzimmermann@...e.de, airlied@...il.com,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 05/15] drm/vkms: Extract vkms_config header

On 11/02/25 - 12:09, José Expósito wrote:
> Creating a new vkms_config structure will be more complex once we
> start adding more options.
> 
> Extract the vkms_config structure to its own header and source files
> and add functions to create and delete a vkms_config and to initialize
> debugfs.
> 
> Refactor, no functional changes.
> 
> Co-developed-by: Louis Chauvet <louis.chauvet@...tlin.com>
> Signed-off-by: Louis Chauvet <louis.chauvet@...tlin.com>
> Signed-off-by: José Expósito <jose.exposito89@...il.com>

This does not build in module, can you add this in the next version?

diff --git a/drivers/gpu/drm/vkms/vkms_config.c b/drivers/gpu/drm/vkms/vkms_config.c
index 152b2ecd6aef..42caa421876e 100644
--- a/drivers/gpu/drm/vkms/vkms_config.c
+++ b/drivers/gpu/drm/vkms/vkms_config.c
@@ -4,6 +4,7 @@

 #include <drm/drm_print.h>
 #include <drm/drm_debugfs.h>
+#include <kunit/visibility.h>

 #include "vkms_config.h"

@@ -17,11 +18,13 @@ struct vkms_config *vkms_config_create(void)

        return config;
 }
+EXPORT_SYMBOL_IF_KUNIT(vkms_config_create);

 void vkms_config_destroy(struct vkms_config *config)
 {
        kfree(config);
 }
+EXPORT_SYMBOL_IF_KUNIT(vkms_config_destroy);

 static int vkms_config_show(struct seq_file *m, void *data)
 {

With this:

Reviewed-by: Louis Chauvet <louis.chauvet@...tlin.com>