linux-kernel - Re: [PATCH v2 04/15] drm/vkms: Add KUnit test scaffolding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6361TEh9vNrBu7j@louis-chauvet-laptop>
Date: Thu, 13 Feb 2025 14:59:49 +0100
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: José Expósito <jose.exposito89@...il.com>
Cc: hamohammed.sa@...il.com, simona@...ll.ch, melissa.srw@...il.com,
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
	tzimmermann@...e.de, airlied@...il.com,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Arthur Grillo <arthurgrillo@...eup.net>
Subject: Re: [PATCH v2 04/15] drm/vkms: Add KUnit test scaffolding

On 11/02/25 - 12:09, José Expósito wrote:
> Add the required boilerplate to start creating KUnit test.
> 
> To run the tests:
> 
>     $ ./tools/testing/kunit/kunit.py run \
>       --kunitconfig=drivers/gpu/drm/vkms/tests
> 
> Co-developed-by: Arthur Grillo <arthurgrillo@...eup.net>
> Signed-off-by: Arthur Grillo <arthurgrillo@...eup.net>
> Co-developed-by: Louis Chauvet <louis.chauvet@...tlin.com>
> Signed-off-by: Louis Chauvet <louis.chauvet@...tlin.com>
> Signed-off-by: José Expósito <jose.exposito89@...il.com>
> ---
>  drivers/gpu/drm/vkms/Kconfig                  | 15 +++++++++++++++
>  drivers/gpu/drm/vkms/Makefile                 |  1 +
>  drivers/gpu/drm/vkms/tests/.kunitconfig       |  4 ++++
>  drivers/gpu/drm/vkms/tests/Makefile           |  3 +++
>  drivers/gpu/drm/vkms/tests/vkms_config_test.c | 19 +++++++++++++++++++
>  5 files changed, 42 insertions(+)
>  create mode 100644 drivers/gpu/drm/vkms/tests/.kunitconfig
>  create mode 100644 drivers/gpu/drm/vkms/tests/Makefile
>  create mode 100644 drivers/gpu/drm/vkms/tests/vkms_config_test.c
> 
> diff --git a/drivers/gpu/drm/vkms/Kconfig b/drivers/gpu/drm/vkms/Kconfig
> index 9def079f685b..d4665e913de7 100644
> --- a/drivers/gpu/drm/vkms/Kconfig
> +++ b/drivers/gpu/drm/vkms/Kconfig
> @@ -14,3 +14,18 @@ config DRM_VKMS
>  	  a VKMS.
>  
>  	  If M is selected the module will be called vkms.
> +
> +config DRM_VKMS_KUNIT_TESTS
> +	tristate "KUnit tests for VKMS." if !KUNIT_ALL_TESTS

If there is a v3, can you remove the dot?

With or without this:

Reviewed-by: Louis Chauvet <louis.chauvet@...tlin.com>

Thanks,
Louis Chauvet