linux-kernel - Re: [PATCH] virtio: console: Prepare for making REMOTEPROC modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d48bcfd0c6030c92f6a5a4a91c9b62f926b3b16.camel@kernel.org>
Date: Fri, 14 Feb 2025 17:55:41 +0100
From: Amit Shah <amit@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman
	 <gregkh@...uxfoundation.org>, virtualization@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio: console: Prepare for making REMOTEPROC modular

On Fri, 2025-02-14 at 17:52 +0100, Uwe Kleine-König wrote:
> Hello Amit,
> 
> On Fri, Feb 14, 2025 at 05:37:52PM +0100, Amit Shah wrote:
> > I'm thinking of the two combinations of interest: REMOTEPROC=m,
> > VIRTIO_CONSOLE can be y or m.  Say virtcons_probe() happens when
> > the
> > remoteproc module isn't yet loaded.  Even after later loading
> > remoteproc, virtio console won't do anything interesting with
> > remoteproc.
> 
> Where does the interesting thing happen if remoteproc is already
> loaded
> at that time? I'm not seeing anything interesting in that case either
> ...

The code I pointed to,

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/char/virtio_console.c#n1993

either enables remoteproc if the module is present; or it enables
multiport, but not both at the same time.  If remoteproc isn't present
when this probe routine is executed, multiport might get enabled.  And
then there's no chance for remoteproc to get enabled.

		Amit