linux-kernel - Re: [PATCH v2 03/12] dt-bindings: crypto: Convert fsl,sec-2.0 to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z66kksKzsknmOy5Q@probook>
Date: Fri, 14 Feb 2025 02:04:02 +0000
From: J. Neuschäfer <j.ne@...teo.net>
To: Rob Herring <robh@...nel.org>
Cc: J. Neuschäfer <j.ne@...teo.net>,
	devicetree@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	Krzysztof Kozlowski <krzk@...nel.org>, imx@...ts.linux.dev,
	Scott Wood <oss@...error.net>,
	Madhavan Srinivasan <maddy@...ux.ibm.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Nicholas Piggin <npiggin@...il.com>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Naveen N Rao <naveen@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Damien Le Moal <dlemoal@...nel.org>,
	Niklas Cassel <cassel@...nel.org>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>, Lee Jones <lee@...nel.org>,
	Vinod Koul <vkoul@...nel.org>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kw@...ux.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	J. Neuschäfer <j.neuschaefer@....net>,
	Wim Van Sebroeck <wim@...ux-watchdog.org>,
	Guenter Roeck <linux@...ck-us.net>, Mark Brown <broonie@...nel.org>,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	Richard Weinberger <richard@....at>,
	Vignesh Raghavendra <vigneshr@...com>, linux-kernel@...r.kernel.org,
	linux-ide@...r.kernel.org, linux-crypto@...r.kernel.org,
	dmaengine@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-watchdog@...r.kernel.org, linux-spi@...r.kernel.org,
	linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v2 03/12] dt-bindings: crypto: Convert fsl,sec-2.0 to YAML

On Wed, Feb 12, 2025 at 01:33:14PM -0600, Rob Herring wrote:
> On Fri, Feb 07, 2025 at 10:30:20PM +0100, J. Neuschäfer wrote:
> > Convert the Freescale security engine (crypto accelerator) binding from
> > text form to YAML. The list of compatible strings reflects what was
> > previously described in prose; not all combinations occur in existing
> > devicetrees.
> > 
> > Signed-off-by: J. Neuschäfer <j.ne@...teo.net>
> > ---
> > 
> > V2:
> > - several improvements suggested by Rob Herring:
> >   - remove unnecessary multiline markers
> >   - constrain fsl,num-channels to enum: [1,4]
> >   - constrain fsl,channel-fifo-len to plausible limits
> >   - constrain fsl,exec-units-mask to maximum=0xfff
> > - trim subject line (remove "binding")
> > ---
> >  .../devicetree/bindings/crypto/fsl,sec2.0.yaml     | 142 +++++++++++++++++++++
> >  .../devicetree/bindings/crypto/fsl-sec2.txt        |  65 ----------
> >  2 files changed, 142 insertions(+), 65 deletions(-)
[...]
> > +title: Freescale SoC SEC Security Engines versions 1.x-2.x-3.x
> > +
> > +maintainers:
> > +  - J. Neuschäfer <j.ne@...teo.net.
> 
> missing >

Good catch, will fix.


> > +  fsl,descriptor-types-mask:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: |
> > +      The bitmask representing what descriptors are available. Descriptor type
> > +      information should be encoded following the SEC's Descriptor Header Dword
> > +      DESC_TYPE field documentation, i.e. as follows:
> > +
> > +        bit 0  = set if SEC supports the aesu_ctr_nonsnoop desc. type
> > +        bit 1  = set if SEC supports the ipsec_esp descriptor type
> > +        bit 2  = set if SEC supports the common_nonsnoop desc. type
> > +        bit 3  = set if SEC supports the 802.11i AES ccmp desc. type
> > +        bit 4  = set if SEC supports the hmac_snoop_no_afeu desc. type
> > +        bit 5  = set if SEC supports the srtp descriptor type
> > +        bit 6  = set if SEC supports the non_hmac_snoop_no_afeu desc.type
> > +        bit 7  = set if SEC supports the pkeu_assemble descriptor type
> > +        bit 8  = set if SEC supports the aesu_key_expand_output desc.type
> > +        bit 9  = set if SEC supports the pkeu_ptmul descriptor type
> > +        bit 10 = set if SEC supports the common_nonsnoop_afeu desc. type
> > +        bit 11 = set if SEC supports the pkeu_ptadd_dbl descriptor type
> 
> Why 3 variations of 'descriptor type'?

The reasons have been lost in time, I suppose. I'll normalize the spelling.


Thanks,
J. Neuschäfer