linux-kernel - Re: [PATCH v6 4/9] KVM: selftests: Add VMGEXIT helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8217a1a-4aba-4e26-9b87-2fd9b6bf92f2@amd.com>
Date: Fri, 14 Feb 2025 12:09:30 -0600
From: Pratik Rajesh Sampat <prsampat@....com>
To: Sean Christopherson <seanjc@...gle.com>
Cc: linux-kernel@...r.kernel.org, x86@...nel.org, kvm@...r.kernel.org,
 linux-crypto@...r.kernel.org, linux-kselftest@...r.kernel.org,
 pbonzini@...hat.com, thomas.lendacky@....com, tglx@...utronix.de,
 mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
 shuah@...nel.org, pgonda@...gle.com, ashish.kalra@....com, nikunj@....com,
 pankaj.gupta@....com, michael.roth@....com, sraithal@....com
Subject: Re: [PATCH v6 4/9] KVM: selftests: Add VMGEXIT helper

On 2/11/25 7:59 PM, Sean Christopherson wrote:
> On Mon, Feb 03, 2025, Pratik R. Sampat wrote:
>> Abstract rep vmmcall coded into the VMGEXIT helper for the sev
>> library.
>>
>> No functional change intended.
>>
>> Reviewed-by: Pankaj Gupta <pankaj.gupta@....com>
>> Tested-by: Srikanth Aithal <sraithal@....com>
>> Signed-off-by: Pratik R. Sampat <prsampat@....com>
>> ---
>> v5..v6:
>>
>> * Collected tags from Pankaj and Srikanth.
>> ---
>>  tools/testing/selftests/kvm/include/x86/sev.h    | 2 ++
>>  tools/testing/selftests/kvm/x86/sev_smoke_test.c | 2 +-
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/kvm/include/x86/sev.h b/tools/testing/selftests/kvm/include/x86/sev.h
>> index 82c11c81a956..e7df5d0987f6 100644
>> --- a/tools/testing/selftests/kvm/include/x86/sev.h
>> +++ b/tools/testing/selftests/kvm/include/x86/sev.h
>> @@ -27,6 +27,8 @@ enum sev_guest_state {
>>  
>>  #define GHCB_MSR_TERM_REQ	0x100
>>  
>> +#define VMGEXIT()		{ __asm__ __volatile__("rep; vmmcall"); }
> 
> Please make this a proper inline function, there's no reason to use a macro.

Sure, I can make this an inline function.