linux-kernel - Re: [PATCH] tty: owl-uart: fix call balance of owl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ci23nalbgrgi5o7zbze4adc54mupn6nymu25konthvtbhyjb7u@z4bteiubsiy6>
Date: Fri, 14 Feb 2025 21:39:09 +0300
From: Fedor Pchelkin <pchelkin@...ras.ru>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: Vitalii Mordan <mordan@...ras.ru>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, 
	Andreas Färber <afaerber@...e.de>, Jeff Johnson <quic_jjohnson@...cinc.com>, 
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Uwe Kleine-König <u.kleine-koenig@...libre.com>, 
	Amit Singh Tomar <amittomer25@...il.com>, linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-actions@...ts.infradead.org, 
	Alexey Khoroshilov <khoroshilov@...ras.ru>, Vadim Mutilin <mutilin@...ras.ru>, lvc-project@...uxtesting.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH] tty: owl-uart: fix call balance of owl_port->clk
 handling routines

On Fri, 14. Feb 22:44, Manivannan Sadhasivam wrote:
> On Thu, Feb 13, 2025 at 02:24:16PM +0300, Vitalii Mordan wrote:
> > If owl_port->clk was enabled in owl_uart_probe(), it must be disabled in
> > all error paths to ensure proper cleanup. However, if uart_add_one_port()
> > returns an error in owl_uart_probe(), the owl_port->clk clock will not be
> > disabled.
> > 
> > Use the devm_clk_get_enabled() helper function to ensure proper call
> > balance for owl_port->clk.
> > 
> 
> Do not use newly introduced APIs to fix old bugs. The bug should be fixed
> separately to allow backporting and the conversion should be done on top.

These relatively new helpers are already available in all currently
supported stable kernels including 5.4.y.

Commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared and
enabled clocks") was conveniently backported there as a dependency for
the similar bug fixes.