linux-kernel - [PATCH v2 4/5] staging: gpib: tnt4882: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250214195456.104075-9-gascoar@gmail.com>
Date: Fri, 14 Feb 2025 16:54:46 -0300
From: Gaston Gonzalez <gascoar@...il.com>
To: linux-staging@...ts.linux.dev
Cc: dpenkler@...il.com,
	gregkh@...uxfoundation.org,
	arnd@...db.de,
	dan.carpenter@...aro.org,
	ajithpv.linux@...il.com,
	roheetchavan@...il.com,
	niharchaithanya@...il.com,
	eleanor15x@...il.com,
	everestkc@...restkc.com.np,
	kees@...erbout.nl,
	skhan@...uxfoundation.org,
	linux-kernel@...r.kernel.org,
	gascoar@...il.com
Subject: [PATCH v2 4/5] staging: gpib: tnt4882: remove unused variable

Remove unused variable 'retval' in function 'tnt4882_update_status'.

A call to nec7210_update_status_nolock() is added as the status bits are written
to board->status in that function.

This change removes the following warning:

warning: variable ‘retval’ set but not used [-Wunused-but-set-variable]

Signed-off-by: Gaston Gonzalez <gascoar@...il.com>
---
v2: add call to nec7210_update_status_nolock() function.

 drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c b/drivers/staging/gpib/tnt4882/tnt4882_gpib.c
index 2e1c3cbebaca..19f6d798f09c 100644
--- a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c
+++ b/drivers/staging/gpib/tnt4882/tnt4882_gpib.c
@@ -704,12 +704,11 @@ static unsigned int tnt4882_update_status(gpib_board_t *board, unsigned int clea
 {
 	unsigned long flags;
 	u8 line_status;
-	unsigned int retval;
 	struct tnt4882_priv *priv = board->private_data;
 
 	spin_lock_irqsave(&board->spinlock, flags);
 	board->status &= ~clear_mask;
-	retval = nec7210_update_status_nolock(board, &priv->nec7210_priv);
+	nec7210_update_status_nolock(board, &priv->nec7210_priv);
 	/* set / clear SRQ state since it is not cleared by interrupt */
 	line_status = tnt_readb(priv, BSR);
 	if (line_status & BCSR_SRQ_BIT)
-- 
2.48.1