linux-kernel - Re: [PATCH v3] ACPI: fan: Add fan speed reporting for fans with only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hMpyANvOgGS8fbWWEZKw+ND-7uwYYfGsHesWLkoPd6FA@mail.gmail.com>
Date: Fri, 14 Feb 2025 21:21:52 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Armin Wolf <W_Armin@....de>
Cc: Joshua Grisham <josh@...huagrisham.com>, rafael@...nel.org, lenb@...nel.org, 
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ACPI: fan: Add fan speed reporting for fans with only _FST

On Fri, Feb 14, 2025 at 5:47 PM Armin Wolf <W_Armin@....de> wrote:
>
> Am 06.02.25 um 08:37 schrieb Joshua Grisham:
>
> > Den tors 6 feb. 2025 kl 06:05 skrev Armin Wolf <W_Armin@....de>:
> >> Am 25.01.25 um 11:07 schrieb Joshua Grisham:
> >>
> >>> Add support for ACPI fans with _FST to report their speed even if they do
> >>> not support fan control.
> >>>
> >>> As suggested by Armin Wolf [1] and per the Windows Thermal Management
> >>> Design Guide [2], Samsung Galaxy Book series devices (and possibly many
> >>> more devices where the Windows guide was strictly followed) only implement
> >>> the _FST method and do not support ACPI-based fan control.
> >>>
> >>> Currently, these fans are not supported by the kernel driver but this patch
> >>> will make some very small adjustments to allow them to be supported.
> >>>
> >>> This patch is tested and working for me on a Samsung Galaxy Book2 Pro whose
> >>> DSDT (and several other Samsung Galaxy Book series notebooks which
> >>> currently have the same issue) can be found at [3].
> >> Any updates on this patch? For me it seems ready for mainline.
> >>
> >> Thanks,
> >> Armin Wolf
> >>
> > Hi Armin, thanks for checking in on this!
> >
> > For me I have no further updates that I planned or intended to send.
> > If it looks good to Rafael or anyone else who wants or needs to review
> > then I would be glad to see it applied.
> >
> > If needed then I can re-send with Armin's Reviewed-by tag inline in
> > the commit message but otherwise everything is as I would have wished
> > it to be, for what that is worth :)
> >
> > Thanks again!
> >
> > Best regards,
> > Joshua
>
> I was hoping to get Rafaels attention so that he can give your patch a closer look.

I'm a bit busy with other things ATM, but I'm planning to get to this
next week (and to a bunch of other pending patches for that matter).

Thanks!