linux-kernel - Re: [PATCH 1/2] drivers/base/memory: Simplify add_boot_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250214145725.708746506f5937acc96783be@linux-foundation.org>
Date: Fri, 14 Feb 2025 14:57:25 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Gavin Shan <gshan@...hat.com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, david@...hat.com,
 osalvador@...e.de, gregkh@...uxfoundation.org, rafael@...nel.org,
 dakr@...nel.org
Subject: Re: [PATCH 1/2] drivers/base/memory: Simplify
 add_boot_memory_block()

On Fri, 14 Feb 2025 16:35:03 +1000 Gavin Shan <gshan@...hat.com> wrote:

> It's unnecessary to keep the variable @section_count in the function
> because the device for the specific memory block will be added if
> any of its memory section is present. The variable @section_count
> records the number of present memory sections in the specific memory
> block, which isn't needed.
> 
> Simplify the function by dropping the variable @section_count. No
> functional change intended.
> 
> ...
>
>  static int __init add_boot_memory_block(unsigned long base_section_nr)
>  {
> -	int section_count = 0;
>  	unsigned long nr;
>  
>  	for (nr = base_section_nr; nr < base_section_nr + sections_per_block;

mm/sparse.c has a for_each_present_section_nr() - is that usable here?

> -	     nr++)
> -		if (present_section_nr(nr))
> -			section_count++;
> +	     nr++) {
> +		if (present_section_nr(nr)) {
> +			return add_memory_block(memory_block_id(base_section_nr),
> +						MEM_ONLINE, NULL, NULL);
> +		}
> +	}
>
> ...
>