linux-kernel - Re: [PATCH net-next 1/3] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea348d0a4b30c4926ba16a6e79cb52196aebcf47.camel@mediatek.com>
Date: Fri, 14 Feb 2025 03:35:10 +0000
From: SkyLake Huang (黃啟澤)
	<SkyLake.Huang@...iatek.com>
To: "daniel@...rotopia.org" <daniel@...rotopia.org>, "andrew@...n.ch"
	<andrew@...n.ch>
CC: "matthias.bgg@...il.com" <matthias.bgg@...il.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "linux@...linux.org.uk" <linux@...linux.org.uk>,
	Steven Liu (劉人豪) <steven.liu@...iatek.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	"hkallweit1@...il.com" <hkallweit1@...il.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "horms@...nel.org" <horms@...nel.org>,
	"dqfext@...il.com" <dqfext@...il.com>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>
Subject: Re: [PATCH net-next 1/3] net: phy: mediatek: Add token ring access
 helper functions in mtk-phy-lib

On Thu, 2025-02-13 at 16:34 +0100, Andrew Lunn wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> > > > Those registers with Mrvl* prefix were originally designed for
> > > > connection with certain Marvell devices. It's our DSP
> > > > parameters.
> > > 
> > > Will this code work with real Marvell devices? Is this PHY
> > > actually
> > > licensed from Marvell?
> > 
> > > From what I understood the tuning of those parameters is required
> > to connect to a Marvell PHY link partner on the other end.
> 
> If so, the naming is bad. I assume you need the same settings for
> Microchip, Atheros, Broadcom, etc. These settings just tune the
> hardware to be standards conforming?
> 
>         Andrew
> 
This part is pretty old old old design. Some compatibility issues were
firstly found on Marvell link partners, so the registers are named
accordingly. And yes, now, those Kf/Kp settings will be used for
connection with other link partners. However, if I change the register
names, it violates our hardware register map application note. If this
does bother, I can add some comments before these macros like:

/* Mrvl* prefix only means that in the very beginning we tune the
 * parameters with Marvell link partners. These settings will be used
 * for all link partners now.
 */

BRs,
Sky