linux-kernel - [PATCH] KVM: SVM: snp_alloc_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250214035932.3414337-1-aik@amd.com>
Date: Fri, 14 Feb 2025 14:59:32 +1100
From: Alexey Kardashevskiy <aik@....com>
To: <linux-crypto@...r.kernel.org>
CC: <linux-kernel@...r.kernel.org>, Ashish Kalra <ashish.kalra@....com>, "Tom
 Lendacky" <thomas.lendacky@....com>, Alexey Kardashevskiy <aik@....com>
Subject: [PATCH] KVM: SVM: snp_alloc_firmware_pages: memory leak

Failure to rmpupdate leads to page(s) leak, fix that.

Signed-off-by: Alexey Kardashevskiy <aik@....com>
---
 drivers/crypto/ccp/sev-dev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
index 2e87ca0e292a..0b5f8ab657c5 100644
--- a/drivers/crypto/ccp/sev-dev.c
+++ b/drivers/crypto/ccp/sev-dev.c
@@ -443,8 +443,10 @@ static struct page *__snp_alloc_firmware_pages(gfp_t gfp_mask, int order)
 		return page;
 
 	paddr = __pa((unsigned long)page_address(page));
-	if (rmp_mark_pages_firmware(paddr, npages, false))
+	if (rmp_mark_pages_firmware(paddr, npages, false)) {
+		__free_pages(page, order);
 		return NULL;
+	}
 
 	return page;
 }
-- 
2.47.1