linux-kernel - Re: [PATCH 2/2] drivers: i3c: Add driver for NXP P3H2x4x i3c-hub device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502141155.osJiWAHL-lkp@intel.com>
Date: Fri, 14 Feb 2025 12:21:13 +0800
From: kernel test robot <lkp@...el.com>
To: Aman Kumar Pandey <aman.kumarpandey@....com>,
	linux-kernel@...r.kernel.org, linux-i3c@...ts.infradead.org,
	alexandre.belloni@...tlin.com, krzk+dt@...nel.org, robh@...nel.org,
	conor+dt@...nel.org, devicetree@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, vikash.bansal@....com,
	priyanka.jain@....com, shashank.rebbapragada@....com,
	Frank.Li@....com, Aman Kumar Pandey <aman.kumarpandey@....com>
Subject: Re: [PATCH 2/2] drivers: i3c: Add driver for NXP P3H2x4x i3c-hub
 device

Hi Aman,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.14-rc2 next-20250213]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Aman-Kumar-Pandey/drivers-i3c-Add-driver-for-NXP-P3H2x4x-i3c-hub-device/20250212-213659
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20250212132227.1348374-2-aman.kumarpandey%40nxp.com
patch subject: [PATCH 2/2] drivers: i3c: Add driver for NXP P3H2x4x i3c-hub device
config: i386-randconfig-r111-20250214 (https://download.01.org/0day-ci/archive/20250214/202502141155.osJiWAHL-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250214/202502141155.osJiWAHL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502141155.osJiWAHL-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/i3c/p3h2x4x/p3h2x4x_i3c_hub_common.c:9:22: sparse: sparse: symbol 'p3h2x4x_ibireq' was not declared. Should it be static?
>> drivers/i3c/p3h2x4x/p3h2x4x_i3c_hub_common.c:15:22: sparse: sparse: symbol 'p3h2x4x_regmap_config' was not declared. Should it be static?
>> drivers/i3c/p3h2x4x/p3h2x4x_i3c_hub_common.c:37:26: sparse: sparse: Using plain integer as NULL pointer
   drivers/i3c/p3h2x4x/p3h2x4x_i3c_hub_common.c: note: in included file (through include/linux/module.h, drivers/i3c/p3h2x4x/p3h2x4x_i3c_hub.h):
   include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true

vim +/p3h2x4x_ibireq +9 drivers/i3c/p3h2x4x/p3h2x4x_i3c_hub_common.c

     8	
   > 9	struct i3c_ibi_setup p3h2x4x_ibireq = {
    10			.handler = p3h2x4x_ibi_handler,
    11			.max_payload_len = P3H2x4x_MAX_PAYLOAD_LEN,
    12			.num_slots = P3H2x4x_NUM_SLOTS,
    13	};
    14	
  > 15	struct regmap_config p3h2x4x_regmap_config = {
    16			.reg_bits = P3H2x4x_REG_BITS,
    17			.val_bits = P3H2x4x_VAL_BITS,
    18		};
    19	
    20	/* p3h2x4x ids (i3c) */
    21	static const struct i3c_device_id p3h2x4x_i3c_ids[] = {
    22		I3C_CLASS(I3C_DCR_HUB, NULL),
    23		{ /* sentinel */ },
    24	};
    25	MODULE_DEVICE_TABLE(i3c, p3h2x4x_i3c_ids);
    26	
    27	/* p3h2x4x ids (i2c) */
    28	static const struct i2c_device_id p3h2x4x_i2c_id_table[] = {
    29		{ "nxp-i3c-hub", P3H2x4x_HUB_ID },
    30		{ /* sentinel */ },
    31	};
    32	MODULE_DEVICE_TABLE(i2c, p3h2x4x_i2c_id_table);
    33	
    34	static const struct of_device_id  p3h2x4x_i2c_of_match[] = {
    35		{
    36			.compatible = "nxp,p3h2x4x",
  > 37			.data =  P3H2x4x_HUB_ID,
    38		},
    39		{ /* sentinel */ },
    40	};
    41	MODULE_DEVICE_TABLE(of, p3h2x4x_i2c_of_match);
    42	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki