linux-kernel - Re: [PATCH v6 37/42] drm/mediatek: mtk_hdmi_common: Assign DDC adapter pointer to bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d42cda0ea5d6ee496cc42b81cc82a6a5e1ba444f.camel@mediatek.com>
Date: Fri, 14 Feb 2025 05:10:37 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>
CC: "robh@...nel.org" <robh@...nel.org>, "jie.qiu@...iatek.com"
	<jie.qiu@...iatek.com>, "kernel@...labora.com" <kernel@...labora.com>,
	"simona@...ll.ch" <simona@...ll.ch>, "mripard@...nel.org"
	<mripard@...nel.org>, "tzimmermann@...e.de" <tzimmermann@...e.de>,
	"dmitry.baryshkov@...aro.org" <dmitry.baryshkov@...aro.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	Lewis Liao (廖柏鈞) <Lewis.Liao@...iatek.com>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, Jitao Shi (石记涛)
	<jitao.shi@...iatek.com>, TommyYL Chen (陳彥良)
	<TommyYL.Chen@...iatek.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "airlied@...il.com" <airlied@...il.com>,
	Ives Chenjh (陳俊弘) <Ives.Chenjh@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "junzhi.zhao@...iatek.com"
	<junzhi.zhao@...iatek.com>
Subject: Re: [PATCH v6 37/42] drm/mediatek: mtk_hdmi_common: Assign DDC
 adapter pointer to bridge

On Thu, 2025-02-13 at 11:38 +0100, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> 
> 
> Il 13/02/25 10:20, CK Hu (胡俊光) ha scritto:
> > On Tue, 2025-02-11 at 12:34 +0100, AngeloGioacchino Del Regno wrote:
> > > External email : Please do not click links or open attachments until you have verified the sender or the content.
> > > 
> > > 
> > > In preparation for adding the new HDMI TX v2 IP driver, assign the
> > > pointer to the DDC adapter to struct drm_bridge during probe.
> > 
> > I could not find where to use hdmi->bridge.ddc in the patch of adding hdmi v2.
> > Could you describe more about where or which function would use this?
> > 
> 
> I have already replied to this exact question a long time ago.
> 
> https://lore.kernel.org/all/b5a77637-64b0-4ed3-9619-e76d094505af@collabora.com/

Sorry, I forget this.

Reviewed-by: CK Hu <ck.hu@...iatek.com>

> 
> Regards,
> Angelo
> 
> > Regards,
> > CK
> > 
> > > 
> > > This commit brings no functional changes.
> > > 
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> > > ---
> > >   drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c
> > > index 5ea45608921c..2c91f65f26fa 100644
> > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c
> > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c
> > > @@ -411,6 +411,7 @@ struct mtk_hdmi *mtk_hdmi_common_probe(struct platform_device *pdev)
> > >          hdmi->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID
> > >                           | DRM_BRIDGE_OP_HPD;
> > >          hdmi->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
> > > +       hdmi->bridge.ddc = hdmi->ddc_adpt;
> > >          hdmi->bridge.vendor = "MediaTek";
> > >          hdmi->bridge.product = "On-Chip HDMI";
> > > 
> > > --
> > > 2.48.1
> > > 
> > 
> 
>