linux-kernel - Re: [PATCH v4 3/3] arm64: dts: exynosautov920: add ufs phy for ExynosAutov920 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c80af2c-d8bb-43bb-ae5f-0ab63a0df2bd@kernel.org>
Date: Fri, 14 Feb 2025 08:22:51 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sowon Na <sowon.na@...sung.com>, robh@...nel.org, conor+dt@...nel.org,
 vkoul@...nel.org, alim.akhtar@...sung.com, kishon@...nel.org
Cc: krzk+dt@...nel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v4 3/3] arm64: dts: exynosautov920: add ufs phy for
 ExynosAutov920 SoC

On 26/12/2024 04:11, Sowon Na wrote:
> Add UFS Phy for ExynosAutov920
> 
> Like ExynosAutov9, this also uses fixed-rate clock nodes until clock driver
> has been supported. The clock nodes are initialized on bootloader stage
> thus we don't need to control them so far.
> 
> Signed-off-by: Sowon Na <sowon.na@...sung.com>
> Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynosautov920.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> index eb446cdc4ab6..c761e0a1c2c4 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> @@ -444,6 +444,17 @@ pinctrl_aud: pinctrl@...60000 {
>  			compatible = "samsung,exynosautov920-pinctrl";
>  			reg = <0x1a460000 0x10000>;
>  		};
> +
> +		ufs_0_phy: phy@...04000 {

Incorrectly placed - not ordered. Don't add new stuff to the end of
lists, files, etc. Entire file is sorted by unit address.

Best regards,
Krzysztof