linux-kernel - Re: [PATCH v2] ALSA: hda: Add error check for snd_ctl_rename_id() in snd_hda_create_dig_out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87frkh2cip.wl-tiwai@suse.de>
Date: Fri, 14 Feb 2025 08:47:42 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: perex@...ex.cz,
	tiwai@...e.com,
	cezary.rojewski@...el.com,
	Julia.Lawall@...ia.fr,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v2] ALSA: hda: Add error check for snd_ctl_rename_id() in snd_hda_create_dig_out_ctls()

On Thu, 13 Feb 2025 08:45:43 +0100,
Wentao Liang wrote:
> 
> Check the return value of snd_ctl_rename_id() in
> snd_hda_create_dig_out_ctls(). Ensure that failures
> are properly handled.
> 
> Fixes: 5c219a340850 ("ALSA: hda: Fix kctl->id initialization")
> Cc: stable@...r.kernel.org # 6.4+
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>

The error would never happen because this is a rename, and the only
error condition of snd_ctl_rename_id() is the lack of the control id.
But it's better to have a return check in the caller side, so I took
now.  Thanks.


Takashi