linux-kernel - Re: [PATCH] arm64: dts: ti: k3-am62p-j722s-common-wakeup: Configure ti-sysc for wkup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250214080523.efqvheeso5xoai6p@lcpd911>
Date: Fri, 14 Feb 2025 13:35:23 +0530
From: Dhruva Gole <d-gole@...com>
To: Kendall Willis <k-willis@...com>
CC: <nm@...com>, <vigneshr@...com>, <kristo@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <tony@...mide.com>,
        <msp@...libre.com>, <khilman@...libre.com>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am62p-j722s-common-wakeup: Configure
 ti-sysc for wkup_uart0

On Feb 12, 2025 at 15:52:48 -0600, Kendall Willis wrote:
> From: Vibhore Vardhan <vibhore@...com>
> 
> Similar to the TI K3-AM62x Soc commit ce27f7f9e328c8582a169f97f1466976561f1
> ("arm64: dts: ti: k3-am62-wakeup: Configure ti-sysc for wkup_uart0")
> The devices in the wkup domain are capable of waking up the system from
> suspend. We can configure the wkup domain devices in a generic way using
> the ti-sysc interconnect target module driver like we have done with the
> earlier TI SoCs.
> 
> As ti-sysc manages the SYSCONFIG related registers independent of the
> child hardware device, the wake-up configuration is also set even if
> wkup_uart0 is reserved by sysfw.
> 
> The wkup_uart0 device has interconnect target module register mapping like
> dra7 wkup uart. There is a 1 MB interconnect target range with one uart IP
> block in the target module. The power domain and clock affects the whole
> interconnect target module.
> 
> Note we change the functional clock name to follow the ti-sysc binding
> and use "fck" instead of "fclk".
> 
> Also note that we need to disable the target module reset as noted by
> Markus. Otherwise the sysfw using wkup_uart0 can get confused on some
> devices leading to boot time issues such as mbox timeouts.
> 
> Signed-off-by: Vibhore Vardhan <vibhore@...com>
> Signed-off-by: Kendall Willis <k-willis@...com>
> ---
> Tested by suspend/resume with WKUP UART wakeup source on AM62P.
> 
> Similar patch was sent for AM62x by Tony,
> https://lore.kernel.org/all/20231219072503.12427-1-tony@atomide.com/
> 
> Similar patch was sent for AM62a by Dhruva,
> https://lore.kernel.org/all/20241231-am62a-dt-ti-sysc-wkup-v1-1-a9b0d18a2649@ti.com/
> 
> Original patch for AM62p existed in the TI Vendor tree with Vibhore's
> authorship:
> https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?h=ti-linux-6.6.y&id=efab3fb636673837886599a49cddf1e862c8aeb6
> ---

Reviewed-by: Dhruva Gole <d-gole@...com>


-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated