linux-kernel - Re: [PATCH 4/4] [PATCH 4/4] arm64: dts: marvell: cp11x: Add reset controller node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250214-famous-rainbow-pig-d4bd3b@krzk-bin>
Date: Fri, 14 Feb 2025 09:48:57 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wilson Ding <dingwei@...vell.com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, andrew@...n.ch, gregory.clement@...tlin.com, 
	sebastian.hesselbarth@...il.com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	p.zabel@...gutronix.de, salee@...vell.com, gakula@...vell.com
Subject: Re: [PATCH 4/4] [PATCH 4/4] arm64: dts: marvell: cp11x: Add reset
 controller node

On Thu, Feb 13, 2025 at 10:58:33PM -0800, Wilson Ding wrote:
> The unit soft-reset configuration register is part of the system
> controller register.
> 
> Signed-off-by: Wilson Ding <dingwei@...vell.com>
> ---
>  arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> index 161beec0b6b0..b82003df15e0 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> @@ -273,6 +273,12 @@ CP11X_LABEL(gpio2): gpio@140 {
>  					 <&CP11X_LABEL(clk) 1 17>;
>  				status = "disabled";
>  			};
> +
> +			CP11X_LABEL(soft_reset): soft-reset@268 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Usually: reset-controller

Best regards,
Krzysztof