linux-kernel - Re: [PATCH 7/8] media: rzg2l-cru: rzg2l-core: Use temporary variable for struct device in rzg2l_cru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250214004924.GF8393@pendragon.ideasonboard.com>
Date: Fri, 14 Feb 2025 02:49:24 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Tommaso Merciai <tomm.merciai@...il.com>
Cc: linux-renesas-soc@...r.kernel.org, linux-media@...r.kernel.org,
	biju.das.jz@...renesas.com, prabhakar.mahadev-lad.rj@...renesas.com,
	Tommaso Merciai <tommaso.merciai.xr@...renesas.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Magnus Damm <magnus.damm@...il.com>,
	Hans Verkuil <hverkuil@...all.nl>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/8] media: rzg2l-cru: rzg2l-core: Use temporary variable
 for struct device in rzg2l_cru_probe()

Hi Tommaso, Prabhakar,

Thank you for the patch.

On Mon, Feb 10, 2025 at 12:45:39PM +0100, Tommaso Merciai wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> 
> Use a temporary variable for the struct device pointers to avoid
> dereferencing.

Same comments as for 5/8.

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>

> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>
> ---
>  .../platform/renesas/rzg2l-cru/rzg2l-core.c   | 29 ++++++++++---------
>  1 file changed, 15 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c
> index 89be584a4988..70fed0ce45ea 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c
> @@ -240,10 +240,11 @@ static int rzg2l_cru_media_init(struct rzg2l_cru_dev *cru)
>  
>  static int rzg2l_cru_probe(struct platform_device *pdev)
>  {
> +	struct device *dev = &pdev->dev;
>  	struct rzg2l_cru_dev *cru;
>  	int irq, ret;
>  
> -	cru = devm_kzalloc(&pdev->dev, sizeof(*cru), GFP_KERNEL);
> +	cru = devm_kzalloc(dev, sizeof(*cru), GFP_KERNEL);
>  	if (!cru)
>  		return -ENOMEM;
>  
> @@ -251,32 +252,32 @@ static int rzg2l_cru_probe(struct platform_device *pdev)
>  	if (IS_ERR(cru->base))
>  		return PTR_ERR(cru->base);
>  
> -	cru->presetn = devm_reset_control_get_shared(&pdev->dev, "presetn");
> +	cru->presetn = devm_reset_control_get_shared(dev, "presetn");
>  	if (IS_ERR(cru->presetn))
> -		return dev_err_probe(&pdev->dev, PTR_ERR(cru->presetn),
> +		return dev_err_probe(dev, PTR_ERR(cru->presetn),
>  				     "Failed to get cpg presetn\n");
>  
> -	cru->aresetn = devm_reset_control_get_exclusive(&pdev->dev, "aresetn");
> +	cru->aresetn = devm_reset_control_get_exclusive(dev, "aresetn");
>  	if (IS_ERR(cru->aresetn))
> -		return dev_err_probe(&pdev->dev, PTR_ERR(cru->aresetn),
> +		return dev_err_probe(dev, PTR_ERR(cru->aresetn),
>  				     "Failed to get cpg aresetn\n");
>  
> -	cru->vclk = devm_clk_get(&pdev->dev, "video");
> +	cru->vclk = devm_clk_get(dev, "video");
>  	if (IS_ERR(cru->vclk))
> -		return dev_err_probe(&pdev->dev, PTR_ERR(cru->vclk),
> +		return dev_err_probe(dev, PTR_ERR(cru->vclk),
>  				     "Failed to get video clock\n");
>  
> -	cru->dev = &pdev->dev;
> -	cru->info = of_device_get_match_data(&pdev->dev);
> +	cru->dev = dev;
> +	cru->info = of_device_get_match_data(dev);
>  
>  	irq = platform_get_irq(pdev, 0);
>  	if (irq < 0)
>  		return irq;
>  
> -	ret = devm_request_irq(&pdev->dev, irq, rzg2l_cru_irq, 0,
> +	ret = devm_request_irq(dev, irq, rzg2l_cru_irq, 0,
>  			       KBUILD_MODNAME, cru);
>  	if (ret)
> -		return dev_err_probe(&pdev->dev, ret, "failed to request irq\n");
> +		return dev_err_probe(dev, ret, "failed to request irq\n");
>  
>  	platform_set_drvdata(pdev, cru);
>  
> @@ -285,8 +286,8 @@ static int rzg2l_cru_probe(struct platform_device *pdev)
>  		return ret;
>  
>  	cru->num_buf = RZG2L_CRU_HW_BUFFER_DEFAULT;
> -	pm_suspend_ignore_children(&pdev->dev, true);
> -	pm_runtime_enable(&pdev->dev);
> +	pm_suspend_ignore_children(dev, true);
> +	pm_runtime_enable(dev);
>  
>  	ret = rzg2l_cru_media_init(cru);
>  	if (ret)
> @@ -296,7 +297,7 @@ static int rzg2l_cru_probe(struct platform_device *pdev)
>  
>  error_dma_unregister:
>  	rzg2l_cru_dma_unregister(cru);
> -	pm_runtime_disable(&pdev->dev);
> +	pm_runtime_disable(dev);
>  
>  	return ret;
>  }

-- 
Regards,

Laurent Pinchart