linux-kernel - Re: [PATCH] module: don't annotate ROX memory as kmemleak_not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250214091947.GA21726@noisy.programming.kicks-ass.net>
Date: Fri, 14 Feb 2025 10:19:47 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Mike Rapoport <rppt@...nel.org>
Cc: Luis Chamberlain <mcgrof@...nel.org>,
	"Borah, Chaitanya Kumar" <chaitanya.kumar.borah@...el.com>,
	Daniel Gomez <da.gomez@...sung.com>,
	Petr Pavlu <petr.pavlu@...e.com>,
	Sami Tolvanen <samitolvanen@...gle.com>,
	linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org,
	x86@...nel.org
Subject: Re: [PATCH] module: don't annotate ROX memory as kmemleak_not_leak()

On Fri, Feb 14, 2025 at 10:45:31AM +0200, Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@...nel.org>
> 
> The ROX memory allocations are part of a larger vmalloc allocation and
> annotating them with kmemleak_not_leak() confuses kmemleak.
> 
> Skip kmemleak_not_leak() annotations for the ROX areas.
> 
> Fixes: c287c0723329 ("module: switch to execmem API for remapping as RW and restoring ROX")
> Fixes: 64f6a4e10c05 ("x86: re-enable EXECMEM_ROX support")
> Reported-by: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@...el.com>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@...nel.org>
> ---
> 
> Peter, can you take it via tip tree?
> Or you prefer for Luis to pick this up?

Less of a head-ache overall if these things stay together I recon.
So I'll stick it in tip/x86/mm along with the rest of those patches.

Thanks!