linux-kernel - Re: [PATCH] virtio_snd.h: clarify that `controls` depends on VIRTIO_SND_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874j0w3fh1.wl-tiwai@suse.de>
Date: Fri, 14 Feb 2025 12:58:34 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Stefano Garzarella <sgarzare@...hat.com>
Cc: virtualization@...ts.linux.dev,	Eugenio Pérez
 <eperezma@...hat.com>,	Matias Ezequiel Vara Larsen <mvaralar@...hat.com>,
	linux-sound@...r.kernel.org,	Jason Wang <jasowang@...hat.com>,
	linux-kernel@...r.kernel.org,	Anton Yakovlev
 <anton.yakovlev@...nsynergy.com>,	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	"Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH] virtio_snd.h: clarify that `controls` depends on VIRTIO_SND_F_CTLS

On Thu, 13 Feb 2025 17:18:25 +0100,
Stefano Garzarella wrote:
> 
> As defined in the specification, the `controls` field in the configuration
> space is only valid/present if VIRTIO_SND_F_CTLS is negotiated.
> 
>   From https://docs.oasis-open.org/virtio/virtio/v1.3/virtio-v1.3.html:
> 
>   5.14.4 Device Configuration Layout
>     ...
>     controls
>        (driver-read-only) indicates a total number of all available control
>        elements if VIRTIO_SND_F_CTLS has been negotiated.
> 
> Let's use the same style used in virtio_blk.h to clarify this and to avoid
> confusion as happened in QEMU (see link).
> 
> Link: https://gitlab.com/qemu-project/qemu/-/issues/2805
> Signed-off-by: Stefano Garzarella <sgarzare@...hat.com>

Applied now.  Thanks.


Takashi