linux-kernel - Re: [PATCH] staging: gpib: Resolve prefixing 0x with decimal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z68xSay4rBSecuMO@egonzo>
Date: Fri, 14 Feb 2025 13:04:25 +0100
From: Dave Penkler <dpenkler@...il.com>
To: Ajith P V <ajithpv.linux@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gpib: Resolve prefixing 0x with decimal

On Thu, Feb 06, 2025 at 02:58:15PM +0530, Ajith P V wrote:
> - pr_err() of hp82335_attach() in hp82335 uses 0x%u which is defective.
> - The iobase is of u32 and correct prefix is 0x%x.
> - This error reported by checkpatch with below message:
>   ERROR: Prefixing 0x with decimal output is defective
> 
> Signed-off-by: Ajith P V <ajithpv.linux@...il.com>
> ---
>  drivers/staging/gpib/hp_82335/hp82335.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/gpib/hp_82335/hp82335.c b/drivers/staging/gpib/hp_82335/hp82335.c
> index 451d5dc6d340..6ce79b17a419 100644
> --- a/drivers/staging/gpib/hp_82335/hp82335.c
> +++ b/drivers/staging/gpib/hp_82335/hp82335.c
> @@ -274,7 +274,7 @@ static int hp82335_attach(gpib_board_t *board, const gpib_board_config_t *config
>  	case 0xfc000:
>  		break;
>  	default:
> -		pr_err("hp82335: invalid base io address 0x%u\n", config->ibbase);
> +		pr_err("hp82335: invalid base io address 0x%x\n", config->ibbase);
>  		return -EINVAL;
>  	}
>  	if (!request_mem_region(upper_iomem_base, hp82335_upper_iomem_size, "hp82335")) {
> -- 
> 2.43.0
> 
Hi,
Thanks for your patch.
This patch is now superseded by
https://lore.kernel.org/linux-staging/20250214114708.28947-10-dpenkler@gmail.com/T/#u

which uses dev_err instead of pr_err and corrects the defective 
prefix problem also.
-dave