linux-kernel - Re: [PATCH] fuse: don't set file->private_data in fuse_conn_waiting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpegvKGa6RzxNKCDER+hXvKCJuMzeHq-xQaRNYzgQr_9yhUg@mail.gmail.com>
Date: Fri, 14 Feb 2025 14:04:23 +0100
From: Miklos Szeredi <miklos@...redi.hu>
To: Jeff Layton <jlayton@...nel.org>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fuse: don't set file->private_data in fuse_conn_waiting_read

On Fri, 14 Feb 2025 at 13:58, Jeff Layton <jlayton@...nel.org> wrote:

> It's just an unnecessary assignment. Nothing will look at or use
> private_data in this codepath, so there is no need to set it.

I think the reason it was done this way is to return a sane value even
in the case of small reads (i.e. char-by-char).  It's unlikely to
matter in real life, but removing it is not a big enough win to be
worth risking it.

Thanks,
Miklos