linux-kernel - Re: [PATCH] net: freescale: ucc_geth: make ugeth_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b45aa58-3128-44b0-9408-3d7794436cd4@lunn.ch>
Date: Fri, 14 Feb 2025 14:14:29 +0100
From: Andrew Lunn <andrew@...n.ch>
To: xiaopeitux@...mail.com
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, netdev@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	Pei Xiao <xiaopei01@...inos.cn>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] net: freescale: ucc_geth: make ugeth_mac_ops be static

On Fri, Feb 14, 2025 at 02:11:07PM +0800, xiaopeitux@...mail.com wrote:
> From: Pei Xiao <xiaopei01@...inos.cn>
> 
> sparse warning:
>     sparse: symbol 'ugeth_mac_ops' was not declared. Should it be
> static.
> 
> Add static to fix sparse warnings.

While you are touching it, can it also be made const?

struct phylink *phylink_create(struct phylink_config *,
			       const struct fwnode_handle *,
			       phy_interface_t,
			       const struct phylink_mac_ops *);

phylink_create() will accept a const struct *.

	Andrew