linux-kernel - Re: [RFC PATCH V2 1/2] mmc: Update sdhci tune function to return errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8002f01b-97cd-4c30-b00c-c73d0cbccdc3@intel.com>
Date: Sat, 15 Feb 2025 03:05:57 +0200
From: Adrian Hunter <adrian.hunter@...el.com>
To: Erick Shepherd <erick.shepherd@...com>, <linux-kernel@...r.kernel.org>
CC: <linux-mmc@...r.kernel.org>, <ulf.hansson@...aro.org>,
	<avri.altman@....com>, <wsa+renesas@...g-engineering.com>,
	<quic_jjohnson@...cinc.com>, <andy-ld.lu@...iatek.com>,
	<victor.shih@...esyslogic.com.tw>, <keita.aihara@...y.com>,
	<dsimic@...jaro.org>, <cw9316.lee@...sung.com>, <ricardo@...liere.net>
Subject: Re: [RFC PATCH V2 1/2] mmc: Update sdhci tune function to return
 errors

On 6/02/25 23:08, Erick Shepherd wrote:
> Updates the sdhci_execute_tuning function to return the error code
> that was returned by the __sdhci_execute_tuning function.
> Previously this code was only stored in host->tuning_err and not
> actually returned.
> 
> Signed-off-by: Erick Shepherd <erick.shepherd@...com>
> ---
>  drivers/mmc/host/sdhci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index f4a7733a8ad2..b35b8917fa1e 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2967,7 +2967,8 @@ int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode)
>  
>  	sdhci_start_tuning(host);
>  
> -	host->tuning_err = __sdhci_execute_tuning(host, opcode);
> +	err = __sdhci_execute_tuning(host, opcode);
> +	host->tuning_err = err;

SDHCI uses fixed sampling clock if tuning fails.

It is up to drivers to decide what to do with tuning_err.  A driver
can provide the tuning mmc host op, call sdhci_execute_tuning()
and return tuning_err it that is preferred.

>  
>  	sdhci_end_tuning(host);
>  out: