linux-kernel - Re: [PATCH 3/3] VFS: Change vfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502151124.LyMTodTU-lkp@intel.com>
Date: Sat, 15 Feb 2025 12:10:16 +0800
From: kernel test robot <lkp@...el.com>
To: NeilBrown <neilb@...e.de>, Al Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>,
	Trond Myklebust <trondmy@...nel.org>,
	Anna Schumaker <anna@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-nfs@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] VFS: Change vfs_mkdir() to return the dentry.

Hi NeilBrown,

kernel test robot noticed the following build errors:

[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on trondmy-nfs/linux-next driver-core/driver-core-testing driver-core/driver-core-next driver-core/driver-core-linus cifs/for-next xfs-linux/for-next linus/master v6.14-rc2 next-20250214]
[cannot apply to ericvh-v9fs/for-next tyhicks-ecryptfs/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/NeilBrown/nfs-change-mkdir-inode_operation-to-return-alternate-dentry-if-needed/20250214-141741
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20250214052204.3105610-4-neilb%40suse.de
patch subject: [PATCH 3/3] VFS: Change vfs_mkdir() to return the dentry.
config: x86_64-buildonly-randconfig-001-20250215 (https://download.01.org/0day-ci/archive/20250215/202502151124.LyMTodTU-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250215/202502151124.LyMTodTU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502151124.LyMTodTU-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/smb/server/vfs.c: In function 'ksmbd_vfs_mkdir':
>> fs/smb/server/vfs.c:226:9: error: 'entry' undeclared (first use in this function); did you mean 'dentry'?
     226 |         entry = vfs_mkdir(idmap, d_inode(path.dentry), dentry, mode);
         |         ^~~~~
         |         dentry
   fs/smb/server/vfs.c:226:9: note: each undeclared identifier is reported only once for each function it appears in

vim +226 fs/smb/server/vfs.c

   196	
   197	/**
   198	 * ksmbd_vfs_mkdir() - vfs helper for smb create directory
   199	 * @work:	work
   200	 * @name:	directory name that is relative to share
   201	 * @mode:	directory create mode
   202	 *
   203	 * Return:	0 on success, otherwise error
   204	 */
   205	int ksmbd_vfs_mkdir(struct ksmbd_work *work, const char *name, umode_t mode)
   206	{
   207		struct mnt_idmap *idmap;
   208		struct path path;
   209		struct dentry *dentry, *d;
   210		int err;
   211	
   212		dentry = ksmbd_vfs_kern_path_create(work, name,
   213						    LOOKUP_NO_SYMLINKS | LOOKUP_DIRECTORY,
   214						    &path);
   215		if (IS_ERR(dentry)) {
   216			err = PTR_ERR(dentry);
   217			if (err != -EEXIST)
   218				ksmbd_debug(VFS, "path create failed for %s, err %d\n",
   219					    name, err);
   220			return err;
   221		}
   222	
   223		idmap = mnt_idmap(path.mnt);
   224		mode |= S_IFDIR;
   225		d = dentry;
 > 226		entry = vfs_mkdir(idmap, d_inode(path.dentry), dentry, mode);
   227		err = PTR_ERR_OR_ZERO(dentry);
   228		if (!err && dentry != d)
   229			ksmbd_vfs_inherit_owner(work, d_inode(path.dentry), d_inode(d));
   230	
   231		done_path_create(&path, dentry);
   232		if (err)
   233			pr_err("mkdir(%s): creation failed (err:%d)\n", name, err);
   234		return err;
   235	}
   236	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki