linux-kernel - Re: [PATCH] block/merge: remove unnecessary min() with UINT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9c1655a-83c3-4ac7-a601-6f8161cf3c13@oracle.com>
Date: Sat, 15 Feb 2025 07:33:02 +0000
From: John Garry <john.g.garry@...cle.com>
To: Caleb Sander Mateos <csander@...estorage.com>,
        Jens Axboe <axboe@...nel.dk>
Cc: Keith Busch <kbusch@...nel.org>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block/merge: remove unnecessary min() with UINT_MAX

On 14/02/2025 19:36, Caleb Sander Mateos wrote:
> In bvec_split_segs(), max_bytes is an unsigned, so it must be less than
> or equal to UINT_MAX. Remove the unnecessary min().
> 
> Prior to commit 67927d220150 ("block/merge: count bytes instead of
> sectors"), the min() was with UINT_MAX >> 9, so it did have an effect.
> 
> Signed-off-by: Caleb Sander Mateos<csander@...estorage.com>

FWIW:
Reviewed-by: John Garry <john.g.garry@...cle.com>