linux-kernel - Re: [PATCH 0/2] arm64: dts: imx8m: Add pinctrl config definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PA4PR04MB76308879CAA0764BB293C4C3C5F92@PA4PR04MB7630.eurprd04.prod.outlook.com>
Date: Sat, 15 Feb 2025 10:02:03 +0000
From: Maud Spierings | GOcontroll <maudspierings@...ontroll.com>
To: Lucas Stach <l.stach@...gutronix.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam
	<festevam@...il.com>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "imx@...ts.linux.dev"
	<imx@...ts.linux.dev>
Subject: Re: [PATCH 0/2] arm64: dts: imx8m: Add pinctrl config definitions

From: Lucas Stach <l.stach@...gutronix.de>
Sent: Friday, February 14, 2025 5:28 PM
 
>Hi Maud,

>Am Freitag, dem 14.02.2025 um 16:57 +0100 schrieb Maud Spierings via B4
>Relay:
>> Up untill now the extra function mux (pull resistor, etc) has been
>> defined as a raw hex value, this is difficult to interpret. Add
>> definitions for these parts of the pinctrl registers to allow for more
>> readable pinctrl definitions in devictree files.

>I certainly prefer the short form with the hex value, I find that quite
>a bit more readable than very verbose swathes of defines ORed together.
>But each to their own.

I personally prefer it, but it would be accepted if I write a dts using this if it
gets accepted? I am currently working on devicetrees for all of our devices
preferably they would use this.

>> At this point the patch is not complete, some pinctrl definitions set
>> bit 30 (0x40000000) but according to the reference manual this is a
>> reserved field, I currently have no way to identify what the meaning of
>> this bit is, I hope someone in this CC may be able to provide an answer
>> to this. It will then be fixed in the v2 of this patch.

>This is not a mystery bit, it's used by the pinctrl driver to force
>enable the input path of the pad (SION). This is defined in the generic
>i.MX pinctrl binding, see
>Documentation/devicetree/bindings/pinctrl/fsl,imx-pinctrl.txt

I had a suspicion that it was that but got confused because that is a different
register. Will change it to that in v2 somewhere next week.

Kind regards,
Maud Spierings