linux-kernel - Re: [PATCH] clk: samsung: Fix UBSAN panic in samsung_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173962697098.235665.12602558292611832915.b4-ty@linaro.org>
Date: Sat, 15 Feb 2025 14:42:50 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>, 
 Sylwester Nawrocki <s.nawrocki@...sung.com>, 
 Chanwoo Choi <cw00.choi@...sung.com>, Alim Akhtar <alim.akhtar@...sung.com>, 
 Michael Turquette <mturquette@...libre.com>, 
 Stephen Boyd <sboyd@...nel.org>, Stephen Kitt <steve@....org>, 
 "Gustavo A. R. Silva" <gustavo@...eddedor.com>, 
 Will McVicker <willmcvicker@...gle.com>
Cc: kernel-team@...roid.com, linux-samsung-soc@...r.kernel.org, 
 linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: samsung: Fix UBSAN panic in samsung_clk_init()

On Wed, 12 Feb 2025 10:32:52 -0800, Will McVicker wrote:
> With UBSAN_ARRAY_BOUNDS=y, I'm hitting the below panic due to
> dereferencing `ctx->clk_data.hws` before setting
> `ctx->clk_data.num = nr_clks`. Move that up to fix the crash.
> 
>   UBSAN: array index out of bounds: 00000000f2005512 [#1] PREEMPT SMP
>   <snip>
>   Call trace:
>    samsung_clk_init+0x110/0x124 (P)
>    samsung_clk_init+0x48/0x124 (L)
>    samsung_cmu_register_one+0x3c/0xa0
>    exynos_arm64_register_cmu+0x54/0x64
>    __gs101_cmu_top_of_clk_init_declare+0x28/0x60
>    ...
> 
> [...]

Applied, thanks!

[1/1] clk: samsung: Fix UBSAN panic in samsung_clk_init()
      https://git.kernel.org/krzk/linux/c/d19d7345a7bcdb083b65568a11b11adffe0687af

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>