linux-kernel - Re: [PATCH v2 1/3] staging: rtl8723bs: format comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025021510-surround-drainage-1425@gregkh>
Date: Sat, 15 Feb 2025 17:56:54 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Ian To <onlyian4981@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] staging: rtl8723bs: format comments

On Wed, Feb 12, 2025 at 01:22:54AM -0800, Ian To wrote:
> Some comments were not formatted correctly. Reported by checkpatch.
> 
> Signed-off-by: Ian To <onlyian4981@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_security.c | 92 +++++++++----------
>  1 file changed, 46 insertions(+), 46 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
> index 1e9eff01b1aa..f4556ae54352 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_security.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_security.c
> @@ -30,10 +30,10 @@ const char *security_type_str(u8 value)
>  /* WEP related ===== */
>  
>  /*
> -	Need to consider the fragment  situation
> -*/
> + *	Need to consider the fragment  situation
> + */
>  void rtw_wep_encrypt(struct adapter *padapter, u8 *pxmitframe)
> -{																	/*  exclude ICV */
> +{
>  	union {
>  		__le32 f0;
>  		unsigned char f1[4];
> @@ -342,23 +342,23 @@ static const unsigned short Sbox1[2][256] = {      /* Sbox for hash (can be in R
>  	}
>  };
>  
> - /*
> -**********************************************************************
> -* Routine: Phase 1 -- generate P1K, given TA, TK, IV32
> -*
> -* Inputs:
> -*     tk[]      = temporal key                         [128 bits]
> -*     ta[]      = transmitter's MAC address            [ 48 bits]
> -*     iv32      = upper 32 bits of IV                  [ 32 bits]
> -* Output:
> -*     p1k[]     = Phase 1 key                          [ 80 bits]
> -*
> -* Note:
> -*     This function only needs to be called every 2**16 packets,
> -*     although in theory it could be called every packet.
> -*
> -**********************************************************************
> -*/
> +/*
> + **********************************************************************

Why the long line of **** ?

That should not be needed.

> -/**
> +/*

Why are you removing kerneldoc comment style?

>   * omac1_aes_128_vector - One-Key CBC MAC (OMAC1) hash with AES-128
>   * @key: 128-bit key for the hash operation
>   * @num_elem: Number of elements in the data vector
> @@ -1530,7 +1529,7 @@ static int omac1_aes_128_vector(u8 *key, size_t num_elem,
>  	return 0;
>  }
>  
> -/**
> +/*

Same here?

thanks,

greg k-h