linux-kernel - Re: [PATCH v2 3/3] staging: rtl8723bs: remove extra blank lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025021535-riding-darkening-1c0d@gregkh>
Date: Sat, 15 Feb 2025 17:58:03 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Ian To <onlyian4981@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] staging: rtl8723bs: remove extra blank lines

On Wed, Feb 12, 2025 at 01:22:56AM -0800, Ian To wrote:
> Repeated blank lines were present and removed. Reported by checkpatch.
> 
> Signed-off-by: Ian To <onlyian4981@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_security.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
> index e8f583206f92..18f640d48701 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_security.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_security.c
> @@ -123,7 +123,6 @@ void rtw_wep_decrypt(struct adapter  *padapter, u8 *precvframe)
>  
>  		/* calculate icv and compare the icv */
>  		*((u32 *)crc) = ~crc32_le(~0, payload, length - 4);
> -
>  	}

This was not a "repeated blank line".

>  }
>  
> @@ -219,10 +218,8 @@ void rtw_secgetmic(struct mic_data *pmicdata, u8 *dst)
>  	secmicclear(pmicdata);
>  }
>  
> -
>  void rtw_seccalctkipmic(u8 *key, u8 *header, u8 *data, u32 data_len, u8 *mic_code, u8 pri)
>  {
> -
>  	struct mic_data	micdata;
>  	u8 priority[4] = {0x0, 0x0, 0x0, 0x0};
>  

Neither was that :(

I've stopped reviewing here.

thanks,

greg k-h