linux-kernel - Re: [PATCH 0/6] rust: page: Support borrowing `struct page` and physaddr conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cae5503e-4330-4c44-8a50-1ebf63ea5a24@asahilina.net>
Date: Sun, 16 Feb 2025 04:47:22 +0900
From: Asahi Lina <lina@...hilina.net>
To: Abdiel Janulgue <abdiel.janulgue@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <benno.lossin@...ton.me>,
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>, Jann Horn <jannh@...gle.com>,
 Matthew Wilcox <willy@...radead.org>, Paolo Bonzini <pbonzini@...hat.com>,
 Wedson Almeida Filho <wedsonaf@...il.com>,
 Valentin Obst <kernel@...entinobst.de>,
 Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
 airlied@...hat.com, rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org, asahi@...ts.linux.dev,
 Danilo Krummrich <dakr@...nel.org>
Subject: Re: [PATCH 0/6] rust: page: Support borrowing `struct page` and
 physaddr conversion

On 2/3/25 11:41 PM, Asahi Lina wrote:
> 
> 
> On 2/3/25 7:22 PM, Danilo Krummrich wrote:
>> Hi Lina,
>>
>> On Sun, Feb 02, 2025 at 10:05:42PM +0900, Asahi Lina wrote:
>>> This series refactors the existing Page wrapper to support borrowing
>>> `struct page` objects without ownership on the Rust side, and converting
>>> page references to/from physical memory addresses.
>>
>> Thanks for picking this up!
>>
>> As you know, this has been previously worked on by Abdiel. Kindly drop a note
>> if you intend to pick up something up next time, such that we don't end up doing
>> duplicated work.
> 
> Sorry! I wasn't sure if this was going to end up submitted over the
> holidays so I wasn't in a rush, but I ended up switching gears in the
> past couple of weeks and I really needed this feature now (for crashdump
> support to debug a really annoying firmware crash).
> 
> I actually only just noticed that the previous v2 already had
> Owned/Ownable... I only saw the v3 which didn't, so I didn't realize
> there was already a version of that approach in the past.
> 
> ~~ Lina

Given the discussion in the other subthreads, it looks like this is not
the best approach for page table management and using it for crash dumps
of arbitrary physical memory pages raises some eyebrows, so I'm going to
abandon this series.

Abdiel, if the first two patches are helpful to your work, please feel
free to incorporate them into a v4. Otherwise, just go ahead with
whatever works for you!

~~ Lina