linux-kernel - Re: [PATCH v5 08/16] x86/stackprotector/64: Convert to normal percpu variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250215211854.GFZ7EEvlYTQ2USmKiW@fat_crate.local>
Date: Sat, 15 Feb 2025 22:18:54 +0100
From: Borislav Petkov <bp@...en8.de>
To: Brian Gerst <brgerst@...il.com>
Cc: linux-kernel@...r.kernel.org, x86@...nel.org,
	Ingo Molnar <mingo@...nel.org>, "H . Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ard Biesheuvel <ardb@...nel.org>, Uros Bizjak <ubizjak@...il.com>
Subject: Re: [PATCH v5 08/16] x86/stackprotector/64: Convert to normal percpu
 variable

On Sat, Feb 15, 2025 at 12:38:21PM -0500, Brian Gerst wrote:
> The convention appears to me to be that all caps are used for global
> variables used by the core build scripts and/or exported to
> subdirectory makefiles, whereas lower case is for local variables.

First time I hear of such a convention:

$ git grep -w ACCUMULATE_OUTGOING_ARGS
arch/x86/Makefile:213:  ACCUMULATE_OUTGOING_ARGS := 1
arch/x86/Makefile:217:ifeq ($(ACCUMULATE_OUTGOING_ARGS), 1)

That one should be lowercase too I guess.

> PS.  Please comment on the most recent patch series, v6.

Ok.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette