linux-kernel - Re: [PATCH 1/2 V4] ASoC: dt-bindings: Add cmx655 codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cdbb8176-d109-4a31-9393-5e1ae6767170@kernel.org>
Date: Sun, 16 Feb 2025 14:06:49 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nikola Jelic <nikola.jelic83@...il.com>
Cc: lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz, tiwai@...e.com,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, rwalton@...micro.com
Subject: Re: [PATCH 1/2 V4] ASoC: dt-bindings: Add cmx655 codec

On 16/02/2025 14:03, Krzysztof Kozlowski wrote:
> On Fri, Feb 14, 2025 at 10:58:01PM +0100, Nikola Jelic wrote:
>> Signed-off-by: Nikola Jelic <nikola.jelic83@...il.com>
>>
>> ---
>> V3 -> V4: review remarks
> 
> You keep sending the same, not responding to comments and not fixing
> them. Still nothing improved - same problems as v1.
> 
> What above changelog even mean?
> 
> Please respond to the feedback, the best to the v1 which you received,
> that you acknowledge and implement it. If you have questions, then ask.
> Sending something with the same mistakes for 5th or 6th time means we do
> not understand each other.
To recap, feedback from v1 to respond to:

Please run scripts/checkpatch.pl and fix reported warnings. After that,
run also `scripts/checkpatch.pl --strict` and (probably) fix more
warnings. Some warnings can be ignored, especially from --strict run,
but the code here looks like it needs a fix. Feel free to get in touch
if the warning is not clear.

Feedback from v3: go to v3 and respond or implement. Your changelog
suggests nothing changed or it is just not precise enough.


Best regards,
Krzysztof