linux-kernel - Re: [PATCH net-next v5 7/8] net: pktgen: remove all superfluous index assignements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250216141503.GF1615191@kernel.org>
Date: Sun, 16 Feb 2025 14:15:03 +0000
From: Simon Horman <horms@...nel.org>
To: Peter Seiderer <ps.report@....net>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <shuah@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
	Artem Chernyshev <artem.chernyshev@...-soft.ru>,
	Nam Cao <namcao@...utronix.de>,
	Frederic Weisbecker <frederic@...nel.org>
Subject: Re: [PATCH net-next v5 7/8] net: pktgen: remove all superfluous
 index assignements

On Thu, Feb 13, 2025 at 12:19:19PM +0100, Peter Seiderer wrote:
> Remove all superfluous index ('i += len') assignements (value not used
> afterwards).
> 
> Signed-off-by: Peter Seiderer <ps.report@....net>
> ---
> Changes v4 -> v5
>   - new patch (suggested by Simon Horman)
> ---
>  net/core/pktgen.c | 52 ++++++-----------------------------------------
>  1 file changed, 6 insertions(+), 46 deletions(-)

Thanks Peter,

I went through each of these and they all seem to be cases
where i is incremented but the function returns without using
the new value of i.

Reviewed-by: Simon Horman <horms@...nel.org>