linux-kernel - Re: [PATCH v4 3/6] iio: adc: ad4030: add averaging support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250216153906.6191fded@jic23-huawei>
Date: Sun, 16 Feb 2025 15:39:06 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: kernel test robot <lkp@...el.com>
Cc: Esteban Blanc <eblanc@...libre.com>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Nuno
 Sá <nuno.sa@...log.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Jonathan Corbet <corbet@....net>, oe-kbuild-all@...ts.linux.dev,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v4 3/6] iio: adc: ad4030: add averaging support

On Sun, 16 Feb 2025 03:00:59 +0800
kernel test robot <lkp@...el.com> wrote:

> Hi Esteban,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on a64dcfb451e254085a7daee5fe51bf22959d52d3]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Esteban-Blanc/dt-bindings-iio-adc-add-ADI-ad4030-ad4630-and-ad4632/20250214-202727
> base:   a64dcfb451e254085a7daee5fe51bf22959d52d3
> patch link:    https://lore.kernel.org/r/20250214-eblanc-ad4630_v1-v4-3-135dd66cab6a%40baylibre.com
> patch subject: [PATCH v4 3/6] iio: adc: ad4030: add averaging support
> config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20250216/202502160240.IoVS8Klu-lkp@intel.com/config)
> compiler: alpha-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250216/202502160240.IoVS8Klu-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202502160240.IoVS8Klu-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/iio/adc/ad4030.c: In function 'ad4030_get_chan_scale':
> >> drivers/iio/adc/ad4030.c:375:27: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]  
>      375 |                 scan_type = iio_get_current_scan_type(indio_dev,
>          |                           ^
> 
> 
I applied
diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c
index ed31a3d1d13b..d026535e5d9b 100644
--- a/drivers/iio/adc/ad4030.c
+++ b/drivers/iio/adc/ad4030.c
@@ -369,7 +369,7 @@ static int ad4030_get_chan_scale(struct iio_dev *indio_dev,
                                 int *val2)
 {
        struct ad4030_state *st = iio_priv(indio_dev);
-       struct iio_scan_type *scan_type;
+       const struct iio_scan_type *scan_type;
 
        if (chan->differential) {
                scan_type = iio_get_current_scan_type(indio_dev,

Whilst picking this up.

> vim +/const +375 drivers/iio/adc/ad4030.c
> 
>    365	
>    366	static int ad4030_get_chan_scale(struct iio_dev *indio_dev,
>    367					 struct iio_chan_spec const *chan,
>    368					 int *val,
>    369					 int *val2)
>    370	{
>    371		struct ad4030_state *st = iio_priv(indio_dev);
>    372		struct iio_scan_type *scan_type;
>    373	
>    374		if (chan->differential) {
>  > 375			scan_type = iio_get_current_scan_type(indio_dev,  
>    376							      st->chip->channels);
>    377			*val = (st->vref_uv * 2) / MILLI;
>    378			*val2 = scan_type->realbits;
>    379			return IIO_VAL_FRACTIONAL_LOG2;
>    380		}
>    381	
>    382		*val = st->vref_uv / MILLI;
>    383		*val2 = chan->scan_type.realbits;
>    384		return IIO_VAL_FRACTIONAL_LOG2;
>    385	}
>    386	
>