linux-kernel - Re: [PATCH] selftests: make shell scripts POSIX-compliant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7IOR2UNzjy7cQA7@slm.duckdns.org>
Date: Sun, 16 Feb 2025 06:11:51 -1000
From: Tejun Heo <tj@...nel.org>
To: Aditya Dutt <duttaditya18@...il.com>
Cc: Shuah Khan <shuah@...nel.org>,
	Madhavan Srinivasan <maddy@...ux.ibm.com>,
	"David S . Miller" <davem@...emloft.net>,
	Shuah Khan <skhan@...uxfoundation.org>,
	linux-kernel-mentees@...ts.linuxfoundation.org,
	cgroups@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] selftests: make shell scripts POSIX-compliant

On Sun, Feb 16, 2025 at 05:32:25PM +0530, Aditya Dutt wrote:
> Changes include:
> - Replaced [[ ... ]] with [ ... ]
> - Replaced == with =
> - Replaced printf -v with cur=$(printf ...).
> - Replaced echo -e with printf "%b\n" ...
> 
> The above mentioned are Bash/GNU extensions and are not part of POSIX.
> Using shells like dash or non-GNU coreutils may produce errors.
> They have been replaced with POSIX-compatible alternatives.

Maybe just update them to use /bin/bash instead? There haven't been a lot of
reports of actual breakges and a lot of existing tests are using /bin/bash
already.

Thanks.

-- 
tejun