linux-kernel - Re: [PATCH v3 05/13] gpio: virtuser: convert to use gpio-pseudo utilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202502170056.DR6nbxpY-lkp@intel.com>
Date: Mon, 17 Feb 2025 00:25:44 +0800
From: kernel test robot <lkp@...el.com>
To: Koichiro Den <koichiro.den@...onical.com>, linux-gpio@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, brgl@...ev.pl,
	geert+renesas@...der.be, linus.walleij@...aro.org,
	maciej.borzecki@...onical.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 05/13] gpio: virtuser: convert to use gpio-pseudo
 utilities

Hi Koichiro,

kernel test robot noticed the following build errors:

[auto build test ERROR on brgl/gpio/for-next]
[also build test ERROR on linus/master v6.14-rc2 next-20250214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Koichiro-Den/gpio-aggregator-reorder-functions-to-prepare-for-configfs-introduction/20250216-210413
base:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
patch link:    https://lore.kernel.org/r/20250216125816.14430-6-koichiro.den%40canonical.com
patch subject: [PATCH v3 05/13] gpio: virtuser: convert to use gpio-pseudo utilities
config: i386-buildonly-randconfig-003-20250216 (https://download.01.org/0day-ci/archive/20250217/202502170056.DR6nbxpY-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250217/202502170056.DR6nbxpY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502170056.DR6nbxpY-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/gpio/gpio-pseudo.c:62:3: error: call to undeclared function 'kfree'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      62 |                 kfree(common->name);
         |                 ^
   drivers/gpio/gpio-pseudo.c:71:3: error: call to undeclared function 'kfree'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      71 |                 kfree(common->name);
         |                 ^
   drivers/gpio/gpio-pseudo.c:83:2: error: call to undeclared function 'kfree'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      83 |         kfree(common->name);
         |         ^
   3 errors generated.


vim +/kfree +62 drivers/gpio/gpio-pseudo.c

ef524a2229b717 Koichiro Den 2025-02-16  43  
ef524a2229b717 Koichiro Den 2025-02-16  44  int pseudo_gpio_register(struct pseudo_gpio_common *common,
ef524a2229b717 Koichiro Den 2025-02-16  45  			 struct platform_device_info *pdevinfo)
ef524a2229b717 Koichiro Den 2025-02-16  46  {
ef524a2229b717 Koichiro Den 2025-02-16  47  	struct platform_device *pdev;
ef524a2229b717 Koichiro Den 2025-02-16  48  	char *name;
ef524a2229b717 Koichiro Den 2025-02-16  49  
ef524a2229b717 Koichiro Den 2025-02-16  50  	name = kasprintf(GFP_KERNEL, "%s.%u", pdevinfo->name, pdevinfo->id);
ef524a2229b717 Koichiro Den 2025-02-16  51  	if (!name)
ef524a2229b717 Koichiro Den 2025-02-16  52  		return -ENOMEM;
ef524a2229b717 Koichiro Den 2025-02-16  53  
ef524a2229b717 Koichiro Den 2025-02-16  54  	common->driver_bound = false;
ef524a2229b717 Koichiro Den 2025-02-16  55  	common->name = name;
ef524a2229b717 Koichiro Den 2025-02-16  56  	reinit_completion(&common->probe_completion);
ef524a2229b717 Koichiro Den 2025-02-16  57  	bus_register_notifier(&platform_bus_type, &common->bus_notifier);
ef524a2229b717 Koichiro Den 2025-02-16  58  
ef524a2229b717 Koichiro Den 2025-02-16  59  	pdev = platform_device_register_full(pdevinfo);
ef524a2229b717 Koichiro Den 2025-02-16  60  	if (IS_ERR(pdev)) {
ef524a2229b717 Koichiro Den 2025-02-16  61  		bus_unregister_notifier(&platform_bus_type, &common->bus_notifier);
ef524a2229b717 Koichiro Den 2025-02-16 @62  		kfree(common->name);
ef524a2229b717 Koichiro Den 2025-02-16  63  		return PTR_ERR(pdev);
ef524a2229b717 Koichiro Den 2025-02-16  64  	}
ef524a2229b717 Koichiro Den 2025-02-16  65  
ef524a2229b717 Koichiro Den 2025-02-16  66  	wait_for_completion(&common->probe_completion);
ef524a2229b717 Koichiro Den 2025-02-16  67  	bus_unregister_notifier(&platform_bus_type, &common->bus_notifier);
ef524a2229b717 Koichiro Den 2025-02-16  68  
ef524a2229b717 Koichiro Den 2025-02-16  69  	if (!common->driver_bound) {
ef524a2229b717 Koichiro Den 2025-02-16  70  		platform_device_unregister(pdev);
ef524a2229b717 Koichiro Den 2025-02-16  71  		kfree(common->name);
ef524a2229b717 Koichiro Den 2025-02-16  72  		return -ENXIO;
ef524a2229b717 Koichiro Den 2025-02-16  73  	}
ef524a2229b717 Koichiro Den 2025-02-16  74  
ef524a2229b717 Koichiro Den 2025-02-16  75  	common->pdev = pdev;
ef524a2229b717 Koichiro Den 2025-02-16  76  	return 0;
ef524a2229b717 Koichiro Den 2025-02-16  77  }
ef524a2229b717 Koichiro Den 2025-02-16  78  EXPORT_SYMBOL_GPL(pseudo_gpio_register);
ef524a2229b717 Koichiro Den 2025-02-16  79  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki