linux-kernel - Re: [PATCH v5 10/12] iio: adc: xilinx-xadc-core: use devm_kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250216165939.4780c4f4@jic23-huawei>
Date: Sun, 16 Feb 2025 16:59:39 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Raag Jadav <raag.jadav@...el.com>
Cc: arnd@...db.de, gregkh@...uxfoundation.org, rafael@...nel.org,
 linus.walleij@...aro.org, mika.westerberg@...ux.intel.com,
 andriy.shevchenko@...ux.intel.com, dmitry.torokhov@...il.com,
 przemyslaw.kitszel@...el.com, linux-gpio@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
 linux-iio@...r.kernel.org
Subject: Re: [PATCH v5 10/12] iio: adc: xilinx-xadc-core: use
 devm_kmemdup_array()

On Wed, 12 Feb 2025 11:55:11 +0530
Raag Jadav <raag.jadav@...el.com> wrote:

> Convert to use devm_kmemdup_array() and while at it, use source size
> instead of destination.
> 
> Signed-off-by: Raag Jadav <raag.jadav@...el.com>

Seems fine to me.
Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  drivers/iio/adc/xilinx-xadc-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
> index cfbfcaefec0f..e1f8740ae688 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -1245,8 +1245,8 @@ static int xadc_parse_dt(struct iio_dev *indio_dev, unsigned int *conf, int irq)
>  		channel_templates = xadc_us_channels;
>  		max_channels = ARRAY_SIZE(xadc_us_channels);
>  	}
> -	channels = devm_kmemdup(dev, channel_templates,
> -				sizeof(channels[0]) * max_channels, GFP_KERNEL);
> +	channels = devm_kmemdup_array(dev, channel_templates, max_channels,
> +				      sizeof(*channel_templates), GFP_KERNEL);
>  	if (!channels)
>  		return -ENOMEM;
>