linux-kernel - Re: [PATCH 04/10] platform/x86: alienware-wmi-wmax: Modify supported_thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <076a5b8c-e401-4bf0-80f6-130daae61c48@gmx.de>
Date: Sun, 16 Feb 2025 06:49:56 +0100
From: Armin Wolf <W_Armin@....de>
To: Kurt Borja <kuurtb@...il.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: platform-driver-x86@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
 Dell.Client.Kernel@...l.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/10] platform/x86: alienware-wmi-wmax: Modify
 supported_thermal_profiles[]

Am 08.02.25 um 06:16 schrieb Kurt Borja:

> Rename supported_thermal_profiles[] -> supported_profiles[] and change
> it's type to u8 because it stores AWCC thermal IDs.

Reviewed-by: Armin Wolf <W_Armin@....de>

> Signed-off-by: Kurt Borja <kuurtb@...il.com>
> ---
>   drivers/platform/x86/dell/alienware-wmi-wmax.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/dell/alienware-wmi-wmax.c b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> index 57897a0f4296..4a8335d90b5d 100644
> --- a/drivers/platform/x86/dell/alienware-wmi-wmax.c
> +++ b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> @@ -212,7 +212,7 @@ struct wmax_u32_args {
>   struct awcc_priv {
>   	struct wmi_device *wdev;
>   	struct device *ppdev;
> -	enum awcc_thermal_profile supported_thermal_profiles[PLATFORM_PROFILE_LAST];
> +	u8 supported_profiles[PLATFORM_PROFILE_LAST];
>   };
>
>   static const enum platform_profile_option awcc_mode_to_platform_profile[AWCC_PROFILE_LAST] = {
> @@ -606,7 +606,7 @@ static int awcc_platform_profile_set(struct device *dev,
>   	}
>
>   	return awcc_thermal_control(priv->wdev,
> -				    priv->supported_thermal_profiles[profile]);
> +				    priv->supported_profiles[profile]);
>   }
>
>   static int awcc_platform_profile_probe(void *drvdata, unsigned long *choices)
> @@ -643,7 +643,7 @@ static int awcc_platform_profile_probe(void *drvdata, unsigned long *choices)
>
>   		mode = FIELD_GET(AWCC_THERMAL_MODE_MASK, id);
>   		profile = awcc_mode_to_platform_profile[mode];
> -		priv->supported_thermal_profiles[profile] = id;
> +		priv->supported_profiles[profile] = id;
>
>   		set_bit(profile, choices);
>   	}
> @@ -652,7 +652,7 @@ static int awcc_platform_profile_probe(void *drvdata, unsigned long *choices)
>   		return -ENODEV;
>
>   	if (awcc->gmode) {
> -		priv->supported_thermal_profiles[PLATFORM_PROFILE_PERFORMANCE] =
> +		priv->supported_profiles[PLATFORM_PROFILE_PERFORMANCE] =
>   			AWCC_THERMAL_MODE_GMODE;
>
>   		set_bit(PLATFORM_PROFILE_PERFORMANCE, choices);