linux-kernel - Re: [PATCH] dt-bindings:leds: Add function define for POE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31bc5340976761dbf3653ed2802a8988e07b18d5.camel@alliedtelesis.co.nz>
Date: Sun, 16 Feb 2025 21:37:57 +0000
From: Tony O'Brien <Tony.OBrien@...iedtelesis.co.nz>
To: "krzk@...nel.org" <krzk@...nel.org>
CC: "pavel@...nel.org" <pavel@...nel.org>, "lee@...nel.org" <lee@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "robh@...nel.org"
	<robh@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>, Ben Hoelker
	<Ben.Hoelker@...iedtelesis.co.nz>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, Chris Packham <Chris.Packham@...iedtelesis.co.nz>
Subject: Re: [PATCH] dt-bindings:leds: Add function define for POE

Hi Krzysztof -

> Where did these two reviews happen?
They were in-house reviews.  Please feel free to remove them from the
patch.

> Where is any user of this?
We are adding Kernel control of PoE LEDs and thought this might be
useful to others, maybe those working on netdev, or anyone implementing
PoE on their devices.  Also, the Kernel >> Docs >> LEDs page states:
"If required color or function is missing, please submit a patch to
linux-leds@...r.kernel.org", which is included here.

Cheers,
Tony O'Brien

On Thu, 2025-02-13 at 10:31 +0100, Krzysztof Kozlowski wrote:
> On Thu, Feb 13, 2025 at 01:58:41PM +1300, Tony O'Brien wrote:
> > Add a define so network devices with a PoE PSE feature can provide
> > status indications of connected PoE PDs.
> > 
> > Reviewed-by: Ben Hoelker <ben.hoelker@...iedtelesis.co.nz>
> > Reviewed-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> 
> Where did these two reviews happen?
> 
> > Signed-off-by: Tony O'Brien <tony.obrien@...iedtelesis.co.nz>
> > ---
> >  include/dt-bindings/leds/common.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/dt-bindings/leds/common.h b/include/dt-
> > bindings/leds/common.h
> > index 4f017bea0123..3a8958b81c87 100644
> > --- a/include/dt-bindings/leds/common.h
> > +++ b/include/dt-bindings/leds/common.h
> > @@ -94,6 +94,7 @@
> >  #define LED_FUNCTION_MOBILE "mobile"
> >  #define LED_FUNCTION_MTD "mtd"
> >  #define LED_FUNCTION_PANIC "panic"
> > +#define LED_FUNCTION_POE "poe"
> 
> Where is any user of this?
> 
> Best regards,
> Krzysztof
>