linux-kernel - Re: [PATCH 03/27] ASoC: tas2764: Extend driver to SN012776

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72674ddb-6b5f-40b1-bed8-edaf4547b27b@sirena.org.uk>
Date: Sun, 16 Feb 2025 23:54:26 +0000
From: Mark Brown <broonie@...nel.org>
To: Alyssa Rosenzweig <alyssa@...enzweig.io>
Cc: James Calligeros <jcalligeros99@...il.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Shenghao Ding <shenghao-ding@...com>, Kevin Lu <kevin-lu@...com>,
	Baojun Xu <baojun.xu@...com>, Dan Murphy <dmurphy@...com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Shi Fu <shifu0704@...ndersoft.com>,
	Martin Povišer <povik+lin@...ebit.org>,
	Hector Martin <marcan@...can.st>, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	asahi@...ts.linux.dev
Subject: Re: [PATCH 03/27] ASoC: tas2764: Extend driver to SN012776

On Sun, Feb 16, 2025 at 05:58:40PM -0500, Alyssa Rosenzweig wrote:
> >  config SND_SOC_TAS2764
> >  	tristate "Texas Instruments TAS2764 Mono Audio amplifier"
> >  	depends on I2C
> > +	depends on OF

> Do we want to drop support for !OF configurations? The alternative would
> be extra #ifdef soup. I don't know if this is a useful build configuration but we should be deliberate about adding the depends.

If the Apple variants of these chips are making their way into laptops
I'd not be surprised if the other variants might appear in x86 laptops
too.  What's the specific reason for dropping the build coverage, is it
actually getting in the way at all?  We have lots of drivers which build
happily with !OF even if practically speaking they'll never appear on
such systems since it helps improve build coverage which makes life
easier for people doing general coverage.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)