linux-kernel - drivers/remoteproc/omap_remoteproc.c:732: warning: Function parameter or struct member 'is_iomem' not described in 'omap_rproc_da_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202502161648.WZWrFV7I-lkp@intel.com>
Date: Sun, 16 Feb 2025 16:46:42 +0800
From: kernel test robot <lkp@...el.com>
To: Peng Fan <peng.fan@....com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Bjorn Andersson <andersson@...nel.org>,
	Mathieu Poirier <mathieu.poirier@...aro.org>
Subject: drivers/remoteproc/omap_remoteproc.c:732: warning: Function
 parameter or struct member 'is_iomem' not described in 'omap_rproc_da_to_va'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   ad1b832bf1cf2df9304f8eb72943111625c7e5a7
commit: 40df0a91b2a5228ded8e5f75b80d28c96c6831cd remoteproc: add is_iomem to da_to_va
date:   3 years, 11 months ago
config: arm-randconfig-c041-20230507 (https://download.01.org/0day-ci/archive/20250216/202502161648.WZWrFV7I-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250216/202502161648.WZWrFV7I-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502161648.WZWrFV7I-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/remoteproc/omap_remoteproc.c:732: warning: Function parameter or struct member 'is_iomem' not described in 'omap_rproc_da_to_va'


vim +732 drivers/remoteproc/omap_remoteproc.c

34ed5a33b1218e Ohad Ben-Cohen 2011-10-20  716  
530a1b57e8590f Suman Anna     2020-03-24  717  /**
530a1b57e8590f Suman Anna     2020-03-24  718   * omap_rproc_da_to_va() - internal memory translation helper
530a1b57e8590f Suman Anna     2020-03-24  719   * @rproc: remote processor to apply the address translation for
530a1b57e8590f Suman Anna     2020-03-24  720   * @da: device address to translate
530a1b57e8590f Suman Anna     2020-03-24  721   * @len: length of the memory buffer
530a1b57e8590f Suman Anna     2020-03-24  722   *
530a1b57e8590f Suman Anna     2020-03-24  723   * Custom function implementing the rproc .da_to_va ops to provide address
530a1b57e8590f Suman Anna     2020-03-24  724   * translation (device address to kernel virtual address) for internal RAMs
530a1b57e8590f Suman Anna     2020-03-24  725   * present in a DSP or IPU device). The translated addresses can be used
530a1b57e8590f Suman Anna     2020-03-24  726   * either by the remoteproc core for loading, or by any rpmsg bus drivers.
530a1b57e8590f Suman Anna     2020-03-24  727   *
530a1b57e8590f Suman Anna     2020-03-24  728   * Return: translated virtual address in kernel memory space on success,
530a1b57e8590f Suman Anna     2020-03-24  729   *         or NULL on failure.
530a1b57e8590f Suman Anna     2020-03-24  730   */
40df0a91b2a522 Peng Fan       2021-03-06  731  static void *omap_rproc_da_to_va(struct rproc *rproc, u64 da, size_t len, bool *is_iomem)
530a1b57e8590f Suman Anna     2020-03-24 @732  {
530a1b57e8590f Suman Anna     2020-03-24  733  	struct omap_rproc *oproc = rproc->priv;
530a1b57e8590f Suman Anna     2020-03-24  734  	int i;
530a1b57e8590f Suman Anna     2020-03-24  735  	u32 offset;
530a1b57e8590f Suman Anna     2020-03-24  736  
530a1b57e8590f Suman Anna     2020-03-24  737  	if (len <= 0)
530a1b57e8590f Suman Anna     2020-03-24  738  		return NULL;
530a1b57e8590f Suman Anna     2020-03-24  739  
530a1b57e8590f Suman Anna     2020-03-24  740  	if (!oproc->num_mems)
530a1b57e8590f Suman Anna     2020-03-24  741  		return NULL;
530a1b57e8590f Suman Anna     2020-03-24  742  
530a1b57e8590f Suman Anna     2020-03-24  743  	for (i = 0; i < oproc->num_mems; i++) {
530a1b57e8590f Suman Anna     2020-03-24  744  		if (da >= oproc->mem[i].dev_addr && da + len <=
530a1b57e8590f Suman Anna     2020-03-24  745  		    oproc->mem[i].dev_addr + oproc->mem[i].size) {
530a1b57e8590f Suman Anna     2020-03-24  746  			offset = da - oproc->mem[i].dev_addr;
530a1b57e8590f Suman Anna     2020-03-24  747  			/* __force to make sparse happy with type conversion */
530a1b57e8590f Suman Anna     2020-03-24  748  			return (__force void *)(oproc->mem[i].cpu_addr +
530a1b57e8590f Suman Anna     2020-03-24  749  						offset);
530a1b57e8590f Suman Anna     2020-03-24  750  		}
530a1b57e8590f Suman Anna     2020-03-24  751  	}
530a1b57e8590f Suman Anna     2020-03-24  752  
530a1b57e8590f Suman Anna     2020-03-24  753  	return NULL;
530a1b57e8590f Suman Anna     2020-03-24  754  }
530a1b57e8590f Suman Anna     2020-03-24  755  

:::::: The code at line 732 was first introduced by commit
:::::: 530a1b57e8590f2ebbb6a35effa0efa988aabf6c remoteproc/omap: Add the rproc ops .da_to_va() implementation

:::::: TO: Suman Anna <s-anna@...com>
:::::: CC: Bjorn Andersson <bjorn.andersson@...aro.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki